[Feature][Task Plugin] Add DVC task plugin for MLops scenario (#10372) #10407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jieguangzhou
requested review from
kezhenxu94,
zhongjiajie,
Tianqi-Dotes,
songjianet,
Amy0104,
caishunfeng,
SbloodyS and
zhuangchong
as code owners
zhongjiajie
reviewed
Jun 14, 2022
...hinscheduler-task-dvc/src/main/java/org/apache/dolphinscheduler/plugin/task/dvc/DvcTask.java
Outdated
Show resolved
Hide resolved
caishunfeng
reviewed
Jun 14, 2022
Codecov Report
@@ Coverage Diff @@
## dev #10407 +/- ##
============================================
- Coverage 40.85% 40.76% -0.09%
- Complexity 4846 4877 +31
============================================
Files 886 893 +7
Lines 36029 36339 +310
Branches 3999 4065 +66
============================================
+ Hits 14718 14812 +94
- Misses 19852 20066 +214
- Partials 1459 1461 +2
Continue to review full report at Codecov.
|
|
@zhongjiajie @songjianet PTAL |
backend and docs LGTM, please task a look the frontend code @songjianet |
zhuangchong
reviewed
Jun 15, 2022
...hinscheduler-task-dvc/src/main/java/org/apache/dolphinscheduler/plugin/task/dvc/DvcTask.java
Show resolved
Hide resolved
...eduler-task-dvc/src/main/java/org/apache/dolphinscheduler/plugin/task/dvc/DvcParameters.java
Outdated
Show resolved
Hide resolved
Update docs/docs/en/guide/task/dvc.md change repository_name xxxx to <YOUR-NAME-OR-ORG> Co-authored-by: Jiajie Zhong <zhongjiajie955@gmail.com> fix repository name xxx to <YOUR-NAME-OR-ORG> fix doc add fix comment change dvgTaskType to enumeration change TaskTypeEnum to reside in its own source file.
|
SonarCloud Quality Gate failed. |
zhuangchong
approved these changes
Jun 21, 2022
hstdream
pushed a commit
to hstdream/dolphinscheduler
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
DVC (Data Version Control) is an excellent open-source version control system for machine learning projects.
The DVC plugin is used to use the data version management function of DVC on DolphinScheduler, helping users to carry out data version management easily.
The plugin provides the following three functions:
This PR close #10372.
Brief change log
Verify this pull request
Verified by unit test.