-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][python] Correct variable type of SQL type #10464
Conversation
Hi @hiSandog ,please associate issue. |
Hi @hiSandog, when you target to a specific issue, you should use the keyword |
FYI @SbloodyS I change the milestone from 300b3 to 300b2 due to this is a bugfix and we still not close the 300b2 bug fix process |
I wonder why this will not fail our tests, and go to see our SQL task tests. finally I find we just using the variable instead of constants. 🤣 @hiSandog please change dolphinscheduler/dolphinscheduler-python/pydolphinscheduler/tests/tasks/test_sql.py Line 141 in 720a10a
SqlType.SELECT to "1" , using the contants variable in uinttest is a bad choose
|
and you can change the function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting for CI
Codecov Report
@@ Coverage Diff @@
## dev #10464 +/- ##
============================================
- Coverage 40.90% 40.89% -0.01%
- Complexity 4850 4851 +1
============================================
Files 883 883
Lines 35970 35972 +2
Branches 3991 3991
============================================
- Hits 14712 14711 -1
- Misses 19802 19806 +4
+ Partials 1456 1455 -1
Continue to review full report at Codecov.
|
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks to bring this up
(cherry picked from commit f512e3c)
When SQL type tasks are uploaded through Python-Gate, the web page displays an error.
If I create sql type task from web page, the type of sql-type is string.
But when I upload SQL type tasks via Python-Gate, the type of sql-type is int.
So these two sides should be unified.
fix: #10463