Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][UI] Fix rename form not init bug in file manange #10471

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

devosend
Copy link
Contributor

Purpose of the pull request

close #10469

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@devosend devosend added bug Something isn't working UI ui and front end related labels Jun 16, 2022
@devosend devosend added this to the 3.0.0-beta-2 milestone Jun 16, 2022
@devosend devosend self-assigned this Jun 16, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #10471 (13cfd0e) into dev (f512e3c) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #10471      +/-   ##
============================================
- Coverage     40.90%   40.90%   -0.01%     
+ Complexity     4853     4851       -2     
============================================
  Files           883      883              
  Lines         35972    35972              
  Branches       3991     3991              
============================================
- Hits          14715    14713       -2     
- Misses        19802    19803       +1     
- Partials       1455     1456       +1     
Impacted Files Coverage Δ
...lphinscheduler/rpc/common/AbstractRpcCallBack.java 0.00% <0.00%> (-100.00%) ⬇️
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f512e3c...13cfd0e. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jun 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Amy0104 Amy0104 merged commit d1cae60 into apache:dev Jun 16, 2022
devosend added a commit that referenced this pull request Jun 18, 2022
hstdream pushed a commit to hstdream/dolphinscheduler that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [UI] Rename form init bug in file manage
3 participants