Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Could not find or load main class org.apache.zookeeper.ZooKeeperMain #10535

Merged
merged 4 commits into from
Jun 21, 2022

Conversation

Desperado2
Copy link
Contributor

Purpose of the pull request

fix: #10029

Brief change log

update remove-zk-node.sh

Verify this pull request

This pull request is code cleanup without any test coverage.

script/remove-zk-node.sh Outdated Show resolved Hide resolved
@SbloodyS SbloodyS added bug Something isn't working backend labels Jun 21, 2022
@SbloodyS SbloodyS added this to the 3.0.0-beta-2 milestone Jun 21, 2022
@SbloodyS
Copy link
Member

I think this is a serious issue of pseudo-cluster installation. So I put this to 3.0.0-beta-2 milestone. WDYT? @devosend

@SbloodyS SbloodyS added the first time contributor First-time contributor label Jun 21, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #10535 (d96dc67) into dev (cc06eaa) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #10535      +/-   ##
============================================
- Coverage     40.91%   40.90%   -0.02%     
+ Complexity     4874     4871       -3     
============================================
  Files           893      893              
  Lines         36153    36153              
  Branches       4002     4002              
============================================
- Hits          14793    14788       -5     
- Misses        19903    19907       +4     
- Partials       1457     1458       +1     
Impacted Files Coverage Δ
...e/dolphinscheduler/remote/NettyRemotingClient.java 50.00% <0.00%> (-2.78%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 53.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc06eaa...d96dc67. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@SbloodyS
Copy link
Member

Thanks for your contribution. This is a good beginning. Considering that it's your first contribution, I think we can get deep communication, you can contact me through mail or add WeChat(SbloodyS), when mail or added, please tell me who you are. I think I can help to familiar with the Dolphinscheduler if you meet with problems. @Desperado2

@SbloodyS SbloodyS merged commit 4a3dfae into apache:dev Jun 21, 2022
@devosend
Copy link
Contributor

I think this is a serious issue of pseudo-cluster installation. So I put this to 3.0.0-beta-2 milestone. WDYT? @devosend

Agrees with that. I will cherry-pick later.

hstdream pushed a commit to hstdream/dolphinscheduler that referenced this pull request Jun 23, 2022
…rMain (apache#10535)

* Update remove-zk-node.sh

* Update remove-zk-node.sh

* Update remove-zk-node.sh

* Update remove-zk-node.sh
devosend pushed a commit that referenced this pull request Jun 24, 2022
…rMain (#10535)

* Update remove-zk-node.sh

* Update remove-zk-node.sh

* Update remove-zk-node.sh

* Update remove-zk-node.sh

(cherry picked from commit 4a3dfae)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working first time contributor First-time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not find or load main class org.apache.zookeeper.ZooKeeperMain
4 participants