Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement-10279] [Master] Dependent node log output optimization and fix checkstyle #10593

Merged
merged 1 commit into from
Jun 24, 2022
Merged

[Improvement-10279] [Master] Dependent node log output optimization and fix checkstyle #10593

merged 1 commit into from
Jun 24, 2022

Conversation

SbloodyS
Copy link
Member

Purpose of the pull request

close #10279

@SbloodyS SbloodyS added improvement make more easy to user or prompt friendly backend labels Jun 24, 2022
@SbloodyS SbloodyS added this to the 3.0.0-beta-3 milestone Jun 24, 2022
@SbloodyS SbloodyS self-assigned this Jun 24, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #10593 (421c656) into dev (15a8607) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev   #10593      +/-   ##
============================================
- Coverage     40.93%   40.92%   -0.01%     
+ Complexity     4875     4873       -2     
============================================
  Files           895      895              
  Lines         36212    36212              
  Branches       3987     3987              
============================================
- Hits          14824    14821       -3     
- Misses        19922    19927       +5     
+ Partials       1466     1464       -2
Impacted Files Coverage Δ
...ver/master/runner/task/DependentTaskProcessor.java 5.33% <0.00%> (ø)
...org/apache/dolphinscheduler/remote/utils/Host.java 43.47% <0.00%> (-2.18%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 51.38% <0.00%> (-0.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15a8607...421c656. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

caishunfeng
caishunfeng approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng merged commit 397e51f into apache:dev Jun 24, 2022
@SbloodyS SbloodyS deleted the feature_10279 branch June 24, 2022 08:49
zhongjiajie pushed a commit that referenced this pull request Aug 3, 2022
@SbloodyS @zhongjiajie
dependent node log output optimization and fix checkstyle (#10593)
b0113a9 
(cherry picked from commit 397e51f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caishunfeng caishunfeng caishunfeng approved these changes

@ruanwenjun ruanwenjun Awaiting requested review from ruanwenjun ruanwenjun is a code owner

Assignees

@SbloodyS SbloodyS

Labels
backend improvement make more easy to user or prompt friendly
Projects
DolphinScheduler Roadmap
Archived in project
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

[Improvement][Dependent] Dependent node log output optimization
3 participants
@SbloodyS @codecov-commenter @caishunfeng