[Feature-10604] Task name in the copied and imported workflow without copy suffix

[zhuxt2015]

Purpose of the pull request

close #10604

[SbloodyS]

In dev, we split the task instance from the workflow instance. After the task instance is copied, the user will query two task definitions with the same name and content, which will cause some confusion. I think we should discuss about it.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[zhuxt2015]

In dev, we split the task instance from the workflow instance. After the task instance is copied, the user will query two task definitions with the same name and content, which will cause some confusion. I think we should discuss about it.

In my opinion, I only care about whether the tasks under my workflow are successfully executed, and I don't care much about whether the name is duplicated with other workflows.

Instead, copy suffix redundant, but removing the copy suffix is a waste of time for me.

I've also encountered multiple copy suffixes in task name that caused copy failed/

In addition, if the user wants to avoid duplication, the task name can be modified manually.

[zhongjiajie]

It is incompatible change and we need dissuss about it. Maybe some users already have some function base on this behavior.

If we accept this, please notice that we have import function will also add suffix to it

[zhongjiajie]

BTW, it make no sence to me with your word

In my opinion, I only care about whether the tasks under my workflow are successfully executed, and I don't care much about whether the name is duplicated with other workflows.

So the name it is not important in your cases

Instead, copy suffix redundant, but removing the copy suffix is a waste of time for me.
In addition, if the user wants to avoid duplication, the task name can be modified manually.

Seem are opposing viewpoints

[zhongjiajie]

I've also encountered multiple copy suffixes in task name that caused copy failed

But we may take more care about this one

[zhongjiajie]

If we want to remove the copy and import suffix, we should add some incompatible notice in our release note

[SbloodyS]

LGTM

[ruanwenjun]

LGTM

[codecov-commenter]

Codecov Report

Merging #10607 (19c9e31) into dev (4d9db34) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##                dev   #10607   +/-   ##
=========================================
  Coverage     40.49%   40.49%           
+ Complexity     4887     4885    -2     
=========================================
  Files           951      951           
  Lines         37201    37201           
  Branches       4080     4081    +1     
=========================================
  Hits          15064    15064           
  Misses        20614    20614           
  Partials       1523     1523           

Impacted Files	Coverage Δ
...api/service/impl/ProcessDefinitionServiceImpl.java	31.85% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[zhongjiajie]

Did we want to add this to version 3.0.0? @SbloodyS @caishunfeng

[SbloodyS]

Did we want to add this to version 3.0.0? @SbloodyS @caishunfeng

I'm not quite sure about it.