-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature-10629][Improvement] Support multi cluster environments - namespace use cluster #10650
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #10650 +/- ##
=========================================
Coverage 40.71% 40.72%
- Complexity 4820 4827 +7
=========================================
Files 900 900
Lines 36143 36195 +52
Branches 3982 3992 +10
=========================================
+ Hits 14717 14741 +24
- Misses 19972 19992 +20
- Partials 1454 1462 +8
Continue to review full report at Codecov.
|
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/k8s/K8sManager.java
Outdated
Show resolved
Hide resolved
...-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/K8SNamespaceServiceImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM of the backend part.
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
…espace use cluster (apache#10650) * server code * namespace ui * fix dao test * fix test * fix * docs and image update Co-authored-by: qianl4 <qianl4@cicso.com>
Purpose of the pull request
namespace bind to cluster, when namespace operator get config from cluster config
Brief change log
Verify this pull request
This change added tests and can be verified as follows:
close #10629