Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature-10629][Improvement] Support multi cluster environments - namespace use cluster #10650

Merged
merged 8 commits into from
Jul 7, 2022

Conversation

qianli2022
Copy link
Contributor

@qianli2022 qianli2022 commented Jun 28, 2022

Purpose of the pull request

namespace bind to cluster, when namespace operator get config from cluster config

Brief change log

  • Modify cluster update,delete
  • Modify namespace create,update,delete

Verify this pull request

This change added tests and can be verified as follows:

  • Update K8SNamespaceServiceTest
  • Update ClusterServiceTest.

close #10629

@SbloodyS SbloodyS added UI ui and front end related improvement make more easy to user or prompt friendly backend labels Jun 28, 2022
@SbloodyS SbloodyS added this to the 3.1.0-alpha milestone Jun 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2022

Codecov Report

Merging #10650 (f7a1747) into dev (4ac3349) will increase coverage by 0.00%.
The diff coverage is 52.38%.

@@            Coverage Diff            @@
##                dev   #10650   +/-   ##
=========================================
  Coverage     40.71%   40.72%           
- Complexity     4820     4827    +7     
=========================================
  Files           900      900           
  Lines         36143    36195   +52     
  Branches       3982     3992   +10     
=========================================
+ Hits          14717    14741   +24     
- Misses        19972    19992   +20     
- Partials       1454     1462    +8     
Impacted Files Coverage Δ
...che/dolphinscheduler/api/k8s/K8sClientService.java 4.25% <0.00%> (-2.13%) ⬇️
...uler/api/service/impl/K8SNamespaceServiceImpl.java 68.71% <51.21%> (-5.68%) ⬇️
...rg/apache/dolphinscheduler/api/k8s/K8sManager.java 58.53% <54.83%> (+11.16%) ⬆️
...scheduler/api/service/impl/ClusterServiceImpl.java 85.71% <58.33%> (-2.57%) ⬇️
...ache/dolphinscheduler/dao/entity/K8sNamespace.java 75.40% <66.66%> (-1.26%) ⬇️
...heduler/api/controller/K8sNamespaceController.java 80.00% <100.00%> (ø)
.../org/apache/dolphinscheduler/api/enums/Status.java 100.00% <100.00%> (ø)
.../org/apache/dolphinscheduler/common/Constants.java 82.60% <100.00%> (+0.79%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ac3349...f7a1747. Read the comment docs.

caishunfeng
caishunfeng previously approved these changes Jul 4, 2022
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM of the backend part.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

67.4% 67.4% Coverage
0.0% 0.0% Duplication

Copy link
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@caishunfeng caishunfeng merged commit 1e48bbc into apache:dev Jul 7, 2022
zhongjiajie pushed a commit to zhongjiajie/dolphinscheduler that referenced this pull request Jul 10, 2022
…espace use cluster (apache#10650)

* server code

* namespace ui

* fix dao test

* fix test

* fix

* docs and image update

Co-authored-by: qianl4 <qianl4@cicso.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend improvement make more easy to user or prompt friendly UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Improvement] Support multi cluster environments - namespace use cluster
5 participants