Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor][UI] Refactor yarn queue manage using NSpace component. #10680

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

songjianet
Copy link
Member

@songjianet songjianet commented Jun 29, 2022

Purpose of the pull request

ref #10844

image
image

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@songjianet songjianet added UI ui and front end related refactor labels Jun 29, 2022
@songjianet songjianet added this to the 3.1.0-alpha milestone Jun 29, 2022
@songjianet songjianet requested a review from Amy0104 as a code owner June 29, 2022 14:52
@songjianet songjianet self-assigned this Jun 29, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #10680 (32c75b8) into dev (3fbfa27) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 32c75b8 differs from pull request most recent head b1babc5. Consider uploading reports for the commit b1babc5 to get more accurate results

@@             Coverage Diff              @@
##                dev   #10680      +/-   ##
============================================
+ Coverage     40.90%   40.92%   +0.01%     
+ Complexity     4830     4829       -1     
============================================
  Files           897      897              
  Lines         36157    36151       -6     
  Branches       4006     4000       -6     
============================================
+ Hits          14789    14793       +4     
+ Misses        19897    19884      -13     
- Partials       1471     1474       +3     
Impacted Files Coverage Δ
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 53.33% <0.00%> (-1.34%) ⬇️
...rver/master/runner/task/BlockingTaskProcessor.java 75.60% <0.00%> (-0.30%) ⬇️
...eduler/api/service/impl/DataSourceServiceImpl.java 29.41% <0.00%> (ø)
.../dolphinscheduler/plugin/task/datax/DataxTask.java 0.00% <0.00%> (ø)
...cheduler/plugin/task/api/ShellCommandExecutor.java 0.00% <0.00%> (ø)
...er/api/service/impl/TaskDefinitionServiceImpl.java 24.01% <0.00%> (+0.05%) ⬆️
...hinscheduler/plugin/alert/wechat/WeChatSender.java 29.78% <0.00%> (+0.20%) ⬆️
...olphinscheduler/plugin/alert/email/MailSender.java 51.38% <0.00%> (+0.35%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fbfa27...b1babc5. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Amy0104 Amy0104 merged commit cf7776f into apache:dev Jun 30, 2022
@songjianet songjianet deleted the refactor-yarn-queue branch July 2, 2022 03:23
welsh-wen pushed a commit to welsh-wen/dolphinscheduler that referenced this pull request Jul 2, 2022
zhongjiajie pushed a commit to zhongjiajie/dolphinscheduler that referenced this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants