-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] Supports creating or editing resources. #10823
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #10823 +/- ##
============================================
- Coverage 40.66% 40.26% -0.40%
- Complexity 4825 4853 +28
============================================
Files 913 944 +31
Lines 36306 37011 +705
Branches 3989 4049 +60
============================================
+ Hits 14764 14903 +139
- Misses 20068 20609 +541
- Partials 1474 1499 +25
Continue to review full report at Codecov.
|
@hiSandog can we hold this PR for a while until we merge #10792? I think maybe we write code and pass the |
ok |
1cad539
to
ae6aa53
Compare
dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/core/resource_definition.py
Outdated
Show resolved
Hide resolved
dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/core/resource_definition.py
Outdated
Show resolved
Hide resolved
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/python/PythonGateway.java
Show resolved
Hide resolved
restart the failed tests |
dolphinscheduler-python/pydolphinscheduler/tests/core/test_resource_definition.py
Outdated
Show resolved
Hide resolved
dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/core/process_definition.py
Show resolved
Hide resolved
...cheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/ResourcesServiceTest.java
Show resolved
Hide resolved
...ler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ResourcesServiceImpl.java
Outdated
Show resolved
Hide resolved
BTW, I have review comment in #10823 (comment). I think maybe we should better add a new interface named And in public Integer createOrUpdateResource(
String userName, String fullName, String description, String resourceContent) {
return resourceService.createOrUpdateResource(userName, fullName, description, resourceContent);
} |
I restart the failed E2E test |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/python/PythonGateway.java
Show resolved
Hide resolved
...ler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ResourcesServiceImpl.java
Outdated
Show resolved
Hide resolved
...ler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ResourcesServiceImpl.java
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
well done, we currently supported create resource in python api now 👍 🎉 thanks again @hiSandog |
(cherry picked from commit 59cd861)
Our company now deploy and manage scripts automatically through Python-gate, but resource files need to be maintained manually.We find it inconvenient.So, I think Python-gate should supports creating or editing resources.
close: #10822