[fix-10961][alert server]Change the content of alert to an array #11033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kezhenxu94 Hello, can you take a look at it for me？ |
|
PTAL @kezhenxu94 @caishunfeng |
caishunfeng
reviewed
Jul 20, 2022
...heduler-alert-server/src/main/java/org/apache/dolphinscheduler/alert/AlertSenderService.java
Outdated
Show resolved
Hide resolved
caishunfeng
reviewed
Jul 20, 2022
...rt-server/src/test/java/org/apache/dolphinscheduler/alert/runner/AlertSenderServiceTest.java
Outdated
Show resolved
Hide resolved
tracehh
reviewed
Jul 21, 2022
...heduler-alert-server/src/main/java/org/apache/dolphinscheduler/alert/AlertSenderService.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## dev #11033 +/- ##
============================================
- Coverage 40.27% 40.18% -0.10%
- Complexity 4931 4951 +20
============================================
Files 982 988 +6
Lines 37568 37721 +153
Branches 4127 4147 +20
============================================
+ Hits 15130 15157 +27
- Misses 20903 21023 +120
- Partials 1535 1541 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. |
|
@jackfanwan can you solve the conflicts? |
ok |
caishunfeng
reviewed
Jul 29, 2022
...heduler-alert-server/src/main/java/org/apache/dolphinscheduler/alert/AlertSenderService.java
Outdated
Show resolved
Hide resolved
caishunfeng
reviewed
Jul 31, 2022
...rt-email/src/main/java/org/apache/dolphinscheduler/plugin/alert/email/EmailAlertChannel.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
|
@caishunfeng Please clear the commit log when merging PR, there exist a lot of unused log. |
zhuangchong
pushed a commit
that referenced
this pull request
Sep 19, 2022
) * Change the content of alert to an array * Increase unit test coverage * Modify the code format * Modify the code format * Modify judgment statement * Deleting invalid References * Modify the previous code implementation and improve the test data * Modify the code format * Move the location of the Content conversion * Remove useless code * Change the code format * Modify unit tests * Modify unit tests * Modify unit tests * Changing the location of the code * Modify the code Co-authored-by: fanwanlong <fanwanlong@kezaihui.com> Co-authored-by: 范万龙 <fanwanlong@fanwanlongs-MBP.lan>
zhuangchong
added
the
release cherry-pick
xdu-chenrj
pushed a commit
to xdu-chenrj/dolphinscheduler
that referenced
this pull request
Oct 13, 2022
…che#11033) * Change the content of alert to an array * Increase unit test coverage * Modify the code format * Modify the code format * Modify judgment statement * Deleting invalid References * Modify the previous code implementation and improve the test data * Modify the code format * Move the location of the Content conversion * Remove useless code * Change the code format * Modify unit tests * Modify unit tests * Modify unit tests * Changing the location of the code * Modify the code Co-authored-by: fanwanlong <fanwanlong@kezaihui.com> Co-authored-by: 范万龙 <fanwanlong@fanwanlongs-MBP.lan>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the content of alert to an array
close: #10961