[python] Refactor structure to avoid cycle import #11167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, our core and side module dependent on each others. and will cause cycle import in our codebase, especially in issue apache#10905, we try to refactor to solve this problem. This patch do the following change: * Rename module `side` to `models` * Move `core/base` and `core/sidebase` to dir `modules` * Move `configuration` and `default_config.yaml` to the root of pydolphinscheduler
Codecov Report
@@ Coverage Diff @@
## dev #11167 +/- ##
============================================
- Coverage 40.26% 40.23% -0.04%
+ Complexity 4926 4925 -1
============================================
Files 982 982
Lines 37522 37558 +36
Branches 4124 4127 +3
============================================
+ Hits 15110 15112 +2
- Misses 20879 20911 +32
- Partials 1533 1535 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
I think it can go now |
caishunfeng
approved these changes
Jul 28, 2022
zhongjiajie
added a commit
that referenced
this pull request
Sep 17, 2022
Currently, our core and side module dependent on each others. and will cause cycle import in our codebase, especially in issue #10905, we try to refactor to solve this problem. This patch do the following change: * Rename module `side` to `models` * Move `core/base` and `core/sidebase` to dir `modules` * Move `configuration` and `default_config.yaml` to the root of pydolphinscheduler (cherry picked from commit 7a766cb)
zhongjiajie
added
the
release cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our core and side module dependent on each others. and will cause
cycle import in our codebase, especially in issue #10905, we try to refactor
to solve this problem.
This patch do the following change:
sidetomodelscore/baseandcore/sidebaseto dirmodulesconfigurationanddefault_config.yamlto the root of pydolphinscheduler