Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature-9978][UI] add node dependency type feature #11235

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

sketchmind
Copy link
Contributor

add only current node only,preceding nodes,later nodes options to execute process instance
close #9978

Purpose of the pull request

support node dependency type feature like ds1.x,ds2.x

Brief change log

when executing task instances we support forward, backward and only current node execution

Verify this pull request

This pull request is code cleanup without any test coverage.

@github-actions github-actions bot added the UI ui and front end related label Aug 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2022

Codecov Report

Merging #11235 (754749f) into dev (0141aa5) will increase coverage by 0.10%.
The diff coverage is 40.84%.

❗ Current head 754749f differs from pull request most recent head 18086e8. Consider uploading reports for the commit 18086e8 to get more accurate results

@@             Coverage Diff              @@
##                dev   #11235      +/-   ##
============================================
+ Coverage     40.15%   40.25%   +0.10%     
+ Complexity     4953     4841     -112     
============================================
  Files           988      974      -14     
  Lines         37738    37323     -415     
  Branches       4149     4142       -7     
============================================
- Hits          15154    15026     -128     
+ Misses        21043    20749     -294     
- Partials       1541     1548       +7     
Impacted Files Coverage Δ
...che/dolphinscheduler/alert/AlertServerMetrics.java 0.00% <0.00%> (ø)
.../org/apache/dolphinscheduler/common/Constants.java 83.33% <ø> (ø)
...he/dolphinscheduler/dao/entity/TaskGroupQueue.java 66.03% <ø> (ø)
...ler/server/master/event/TaskStateEventHandler.java 0.00% <0.00%> (ø)
...ler/server/master/metrics/MasterServerMetrics.java 0.00% <0.00%> (ø)
...server/master/runner/task/CommonTaskProcessor.java 4.91% <0.00%> (+0.75%) ⬆️
...duler/plugin/task/api/AbstractCommandExecutor.java 0.00% <0.00%> (ø)
...inscheduler/server/worker/metrics/TaskMetrics.java 0.00% <0.00%> (ø)
...nscheduler/service/process/ProcessServiceImpl.java 28.79% <10.00%> (ø)
.../server/master/runner/WorkflowExecuteRunnable.java 7.97% <33.33%> (+0.20%) ⬆️
... and 66 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@SbloodyS SbloodyS added the feature new feature label Aug 1, 2022
* add only current node only,preceding nodes,later nodes options to execute process instance
@sonarcloud
Copy link

sonarcloud bot commented Aug 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@devosend devosend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenboo
Copy link
Contributor

lenboo commented Aug 9, 2022

refer to #10117

Copy link
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amy0104 Amy0104 merged commit c1c6d59 into apache:dev Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] I can't select task node to start rerun
7 participants