Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Improve the document introduction of complement #11275

Merged
merged 26 commits into from
Aug 9, 2022
Merged

[doc] Improve the document introduction of complement #11275

merged 26 commits into from
Aug 9, 2022

Conversation

Zephyrcf
Copy link
Contributor

@Zephyrcf Zephyrcf commented Aug 3, 2022 •
edited
Loading

Purpose of the pull request

Improve the document introduction of complement.

Brief change log

Improve the document introduction of complement.

Verify this pull request

Verified by manual tests.

@SbloodyS SbloodyS added the first time contributor First-time contributor label Aug 3, 2022
@Zephyrcf @lenboo
Update docs/docs/zh/guide/project/workflow-definition.md
9aa0db6 
Co-authored-by: BaoLiang <29528966+lenboo@users.noreply.github.com>
zhongjiajie
zhongjiajie reviewed Aug 3, 2022
View reviewed changes
Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove the img docs/img/new_ui/dev/project/workflow-configuredTiming.png's Chinese comment or change it to English?

docs/docs/en/guide/project/workflow-definition.md Outdated Show resolved Hide resolved
docs/docs/en/guide/project/workflow-definition.md Show resolved Hide resolved
WangJPLeo
WangJPLeo reviewed Aug 3, 2022
View reviewed changes
docs/docs/zh/guide/project/workflow-definition.md Outdated Show resolved Hide resolved
docs/docs/zh/guide/project/workflow-definition.md Outdated Show resolved Hide resolved
docs/docs/zh/guide/project/workflow-definition.md Outdated Show resolved Hide resolved
docs/docs/en/guide/project/workflow-definition.md Outdated Show resolved Hide resolved
@Zephyrcf Zephyrcf requested a review from zhongjiajie August 3, 2022 09:16
lenboo
lenboo previously approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhongjiajie zhongjiajie requested a review from WangJPLeo August 4, 2022 03:05
@zhongjiajie
Copy link
Member

can you re check if you have time @WangJPLeo

WangJPLeo
WangJPLeo reviewed Aug 4, 2022
View reviewed changes
Copy link
Contributor

@WangJPLeo WangJPLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The execution strategy is the parallel complement special case of serial.

docs/docs/en/guide/project/workflow-definition.md Outdated Show resolved Hide resolved
docs/docs/zh/guide/project/workflow-definition.md Outdated Show resolved Hide resolved
docs/docs/zh/guide/project/workflow-definition.md Outdated Show resolved Hide resolved
docs/docs/en/guide/project/workflow-definition.md Outdated Show resolved Hide resolved
@Zephyrcf @WangJPLeo
Update docs/docs/en/guide/project/workflow-definition.md
2cfd9c8 
Co-authored-by: JiPeng Wang <103574007+WangJPLeo@users.noreply.github.com>
@Zephyrcf @WangJPLeo
Update docs/docs/zh/guide/project/workflow-definition.md
46c480c 
Co-authored-by: JiPeng Wang <103574007+WangJPLeo@users.noreply.github.com>
WangJPLeo
WangJPLeo previously approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@WangJPLeo WangJPLeo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @zhongjiajie

@Zephyrcf Zephyrcf changed the title [Doc]Improve the document introduction of complement [doc] Improve the document introduction of complement Aug 7, 2022
@Zephyrcf Zephyrcf requested a review from WangJPLeo August 8, 2022 02:32
WangJPLeo
WangJPLeo previously approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@WangJPLeo WangJPLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mergeable
Copy link

mergeable bot commented Aug 9, 2022

⚠️ This PR do not change database DDL synchronize.

@mergeable mergeable bot removed the sql not sync label Aug 9, 2022
@github-actions github-actions bot removed the backend label Aug 9, 2022
zhongjiajie
zhongjiajie approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for CI

@zhongjiajie zhongjiajie merged commit 8ad6e10 into apache:dev Aug 9, 2022
@zhongjiajie zhongjiajie added this to the 3.0.1 milestone Aug 9, 2022
zhongjiajie pushed a commit that referenced this pull request Sep 17, 2022
@Zephyrcf @zhongjiajie
[doc] Improve the document introduction of complement (#11275)
82a8956 
(cherry picked from commit 8ad6e10)
@zhongjiajie zhongjiajie added the release cherry-pick Mark this issue/PR had cherry-pick for release version label Sep 17, 2022
@Zephyrcf Zephyrcf deleted the dev branch December 1, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenboo lenboo lenboo left review comments

@zhongjiajie zhongjiajie zhongjiajie approved these changes

@WangJPLeo WangJPLeo WangJPLeo left review comments

@Tianqi-Dotes Tianqi-Dotes Awaiting requested review from Tianqi-Dotes

@EricGao888 EricGao888 Awaiting requested review from EricGao888 EricGao888 is a code owner

@caishunfeng caishunfeng Awaiting requested review from caishunfeng

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

Assignees

@Zephyrcf Zephyrcf

Labels
document first time contributor First-time contributor release cherry-pick Mark this issue/PR had cherry-pick for release version
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.
5 participants
@Zephyrcf @zhongjiajie @lenboo @WangJPLeo @SbloodyS