[Feature-7024] Add waiting strategy to support master/worker can recover from registry lost #11368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
requested review from
kezhenxu94,
caishunfeng and
SbloodyS
as code owners
ruanwenjun
force-pushed
the
dev_wenjun_addWaitingStrategy
branch
from
e6bca04
to
2782747
Compare
ruanwenjun
force-pushed
the
dev_wenjun_addWaitingStrategy
branch
4 times, most recently
from
4f60974
to
7c8c4b9
Compare
Codecov Report
@@ Coverage Diff @@
## dev #11368 +/- ##
============================================
- Coverage 39.43% 39.22% -0.22%
Complexity 4622 4622
============================================
Files 980 987 +7
Lines 37260 37543 +283
Branches 4176 4178 +2
============================================
+ Hits 14695 14727 +32
- Misses 21031 21279 +248
- Partials 1534 1537 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ruanwenjun
force-pushed
the
dev_wenjun_addWaitingStrategy
branch
7 times, most recently
from
ffdc43f
to
cf93ac0
Compare
caishunfeng
reviewed
Aug 11, 2022
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/cron/CronUtils.java
Show resolved
Hide resolved
...duler-service/src/main/java/org/apache/dolphinscheduler/service/registry/RegistryClient.java
Show resolved
Hide resolved
...rker/src/main/java/org/apache/dolphinscheduler/server/worker/runner/WorkerManagerThread.java
Show resolved
Hide resolved
ruanwenjun
requested review from
zhongjiajie,
Tianqi-Dotes and
EricGao888
as code owners
ruanwenjun
force-pushed
the
dev_wenjun_addWaitingStrategy
branch
from
e1c56b4
to
0ddea11
Compare
ruanwenjun
force-pushed
the
dev_wenjun_addWaitingStrategy
branch
from
0ddea11
to
9cf8392
Compare
|
SonarCloud Quality Gate failed. |
|
@zhongjiajie This PR has some changes about the doc, please take a look. |
ruanwenjun
added a commit
to ruanwenjun/dolphinscheduler
that referenced
this pull request
Sep 7, 2022
…ver from registry lost (apache#11368) * Add waiting strategy to support master/worker can recover from registry lost * throw exception when zookeeper registry start failed due to interrupted (cherry picked from commit 7ff34c3)
ruanwenjun
added a commit
to ruanwenjun/dolphinscheduler
that referenced
this pull request
Sep 7, 2022
…ver from registry lost (apache#11368) * Add waiting strategy to support master/worker can recover from registry lost * throw exception when zookeeper registry start failed due to interrupted (cherry picked from commit 7ff34c3)
xdu-chenrj
pushed a commit
to xdu-chenrj/dolphinscheduler
that referenced
this pull request
Oct 13, 2022
…ver from registry lost (apache#11368) * Add waiting strategy to support master/worker can recover from registry lost * throw exception when zookeeper registry start failed due to interrupted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Close #7024
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md