Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement-11380][scp-host.sh] Set StrictHostKeyChecking=no option to ssh #11382

Merged
merged 2 commits into from
Aug 11, 2022
Merged

[Improvement-11380][scp-host.sh] Set StrictHostKeyChecking=no option to ssh #11382

merged 2 commits into from
Aug 11, 2022

Conversation

rickchengx
Copy link
Contributor

@rickchengx rickchengx commented Aug 10, 2022 •
edited
Loading

Purpose of the pull request

This PR close: #11380

Even if the password-free account is configured, when the user uses the scp-host.sh script to log in to the machine for the first time, an error (Host key verification failed.) may occur.

So set the -o StrictHostKeyChecking=no option to ssh in scp-hosts.sh.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

@SbloodyS
Copy link
Member

Hi @rickchengx , to target specific issue from PR, we recommend use keyword fix: #issue_id or close: #issue_id or closes: #issue_id in your PR describe(not title, just desc). It would not only connect issue to PR but also close issue automatically when PR is be closed.

@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Aug 10, 2022
@SbloodyS SbloodyS added this to the 3.0.1 milestone Aug 10, 2022
@rickchengx rickchengx changed the title [Improvement][scp-host.sh] Set StrictHostKeyChecking=no option to ssh [Improvement-11380][scp-host.sh] Set StrictHostKeyChecking=no option to ssh Aug 10, 2022
@rickchengx
Copy link
Contributor Author

Hi @rickchengx , to target specific issue from PR, we recommend use keyword fix: #issue_id or close: #issue_id or closes: #issue_id in your PR describe(not title, just desc). It would not only connect issue to PR but also close issue automatically when PR is be closed.

Sure. Thanks for your advice, I've added the keyword close: #issue_id.

@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

SbloodyS
SbloodyS approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@EricGao888 EricGao888 merged commit 3836dd7 into apache:dev Aug 11, 2022
zhuangchong pushed a commit to zhuangchong/incubator-dolphinscheduler that referenced this pull request Sep 16, 2022
@rickchengx @zhuangchong
[Improvement-11380][scp-host.sh] Set StrictHostKeyChecking=no option …
4bed59e 
…to ssh (apache#11382)

* [Improvement][scp-host.sh] Set StrictHostKeyChecking=no option to ssh

* add StrictHostKeyChecking=no option to status-all.sh
@zhuangchong zhuangchong mentioned this pull request Sep 16, 2022
Merged
@zhuangchong zhuangchong added the release cherry-pick Mark this issue/PR had cherry-pick for release version label Sep 16, 2022
caishunfeng pushed a commit that referenced this pull request Sep 16, 2022
@zhuangchong @rickchengx
[Improvement-11380][scp-host.sh] Set StrictHostKeyChecking=no option …
f132b05 
…to ssh (#11382) (#11995)

* [Improvement][scp-host.sh] Set StrictHostKeyChecking=no option to ssh

* add StrictHostKeyChecking=no option to status-all.sh

Co-authored-by: rickchengx <38122586+rickchengx@users.noreply.github.com>
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
@rickchengx @xdu-chenrj
[Improvement-11380][scp-host.sh] Set StrictHostKeyChecking=no option …
f2c345d 
…to ssh (apache#11382)

* [Improvement][scp-host.sh] Set StrictHostKeyChecking=no option to ssh

* add StrictHostKeyChecking=no option to status-all.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricGao888 EricGao888 EricGao888 approved these changes

@SbloodyS SbloodyS SbloodyS approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng

@zhongjiajie zhongjiajie Awaiting requested review from zhongjiajie

Assignees

@rickchengx rickchengx

Labels
backend improvement make more easy to user or prompt friendly release cherry-pick Mark this issue/PR had cherry-pick for release version
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.

[Improvement][scp-host.sh] Set StrictHostKeyChecking=no option to ssh
4 participants
@rickchengx @SbloodyS @EricGao888 @zhuangchong