-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement-11386][UI] Concise the logic available for task action buttons #11419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dolphinscheduler-ui/src/views/projects/workflow/components/dag/dag-context-menu.tsx
Show resolved
Hide resolved
dolphinscheduler-ui/src/views/projects/workflow/components/dag/index.tsx
Outdated
Show resolved
Hide resolved
…uttons * Remove button instead of disable button * Correct the value of releaseState in the compare statement
7038b33
to
6cf60e1
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…uttons (apache#11419) * Remove button instead of disable button * Correct the value of releaseState in the compare statement Co-authored-by: sheldonliu <sheldonliu>
Purpose of the pull request
Concise the logic available for task action buttons
close #11386
Brief change log
Remove button instead of disable button
Correct the value of releaseState in the compare statement
Verify this pull request
This pull request is code cleanup without any test coverage.