Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement-11386][UI] Concise the logic available for task action buttons #11419

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

sketchmind
Copy link
Contributor

@sketchmind sketchmind commented Aug 11, 2022

Purpose of the pull request

Concise the logic available for task action buttons
close #11386

Brief change log

  • Remove button instead of disable button

  • Correct the value of releaseState in the compare statement

Verify this pull request

This pull request is code cleanup without any test coverage.

@github-actions github-actions bot added the UI ui and front end related label Aug 11, 2022
@sketchmind sketchmind marked this pull request as ready for review August 11, 2022 08:45
@Amy0104 Amy0104 added the improvement make more easy to user or prompt friendly label Aug 12, 2022
@Amy0104 Amy0104 added this to the 3.0.1 milestone Aug 12, 2022
labbomb
labbomb previously approved these changes Aug 12, 2022
Copy link
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…uttons

* Remove button instead of disable button

* Correct the value of releaseState in the compare statement
@sonarcloud
Copy link

sonarcloud bot commented Aug 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amy0104 Amy0104 merged commit 376d0a0 into apache:dev Aug 12, 2022
@zhuangchong zhuangchong added the release cherry-pick Mark this issue/PR had cherry-pick for release version label Sep 19, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
…uttons (apache#11419)

* Remove button instead of disable button

* Correct the value of releaseState in the compare statement

Co-authored-by: sheldonliu <sheldonliu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement make more easy to user or prompt friendly release cherry-pick Mark this issue/PR had cherry-pick for release version UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement][UI] Concise the logic available for task action buttons on workflow definition detail page.
4 participants