Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] Fix find last process instance in dependent task is not correct #11424

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

ruanwenjun
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun added this to the 3.0.1 milestone Aug 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2022

Codecov Report

Merging #11424 (b43c2f2) into dev (1613401) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #11424      +/-   ##
============================================
- Coverage     39.44%   39.43%   -0.01%     
  Complexity     4622     4622              
============================================
  Files           980      980              
  Lines         37260    37256       -4     
  Branches       4176     4174       -2     
============================================
- Hits          14696    14693       -3     
+ Misses        21030    21027       -3     
- Partials       1534     1536       +2     
Impacted Files Coverage Δ
...cheduler/server/master/utils/DependentExecute.java 0.00% <ø> (ø)
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 55.12% <0.00%> (-1.29%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@caishunfeng
Copy link
Contributor

PTAL @lenboo @EricJoy2048

Copy link
Contributor

@brave-lee brave-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@brave-lee
Copy link
Contributor

Please pick up to 2.0.7

@brave-lee brave-lee merged commit a2b5219 into apache:dev Aug 12, 2022
ruanwenjun added a commit to ruanwenjun/dolphinscheduler that referenced this pull request Aug 13, 2022
ruanwenjun added a commit to ruanwenjun/dolphinscheduler that referenced this pull request Sep 17, 2022
@caishunfeng caishunfeng added the release cherry-pick Mark this issue/PR had cherry-pick for release version label Sep 17, 2022
caishunfeng pushed a commit that referenced this pull request Sep 17, 2022
@ruanwenjun ruanwenjun deleted the dev_wenjun_fixFindLastProcessBug branch September 19, 2022 12:39
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
@981433814
Copy link
Contributor

Does this change also apply to version 2.x? I see that version 2.x also has this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend release cherry-pick Mark this issue/PR had cherry-pick for release version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants