-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix-11404]: make the common.properties to configurable on values.yaml #11441
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #11441 +/- ##
============================================
- Coverage 39.56% 39.55% -0.01%
Complexity 4630 4630
============================================
Files 980 980
Lines 37282 37278 -4
Branches 4180 4179 -1
============================================
- Hits 14749 14746 -3
+ Misses 20987 20986 -1
Partials 1546 1546
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@yutianaiqingtian maybe we should replace the values in common.properties from common.configmap.* in values.yaml? |
@aspexdaniel exactly It's a bit redundant. but the value the common.configmap.RESOURCE_STORAGE_TYPE is only check on the helm chart and cannot take effect by the application. I think maybe we should split the common.configmap to two part. one is for the environment and another is for the common.properties. |
and set the resource.storage.type default to hdfs
@yutianaiqingtian this is strange though, because I tested 2.0.6 chart with common.configmap.* points to Minio , it worked. From the code I feel it's not that big different between the two version for k8s helm chart. |
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Thanks for your contribution. This is a good beginning. Considering that it's your first contribution, I think we can get deep communication, you can contact me through mail or add WeChat(SbloodyS), when mail or added, please tell me who you are. I think I can help to familiar with the Dolphinscheduler if you meet with problems. @yutianaiqingtian |
apache#11441) and set the resource.storage.type default to hdfs
apache#11441) and set the resource.storage.type default to hdfs
apache#11441) and set the resource.storage.type default to hdfs
and set the resource.storage.type default to hdfs
Purpose of the pull request
fix #11404(#11404)
Brief change log
make the common.properties to configurable on values.yaml and set the default storage type to hdfs and fs.defaultFS
Verify this pull request
This pull request is code cleanup without any test coverage.