-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] New task plugin Pytorch #11498
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #11498 +/- ##
============================================
+ Coverage 39.36% 39.40% +0.03%
- Complexity 4630 4655 +25
============================================
Files 987 993 +6
Lines 37566 37686 +120
Branches 4184 4197 +13
============================================
+ Hits 14789 14851 +62
- Misses 21226 21277 +51
- Partials 1551 1558 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
63dfa45
to
5e9ae4c
Compare
support resource list add pytorch frontend support git python path add doc
78fb0b2
to
baa09e8
Compare
PTAL, thanks @SbloodyS @EricGao888 @songjianet @caishunfeng @zhongjiajie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to use screenshots in english instead of chinese.
...pytorch/src/main/java/org/apache/dolphinscheduler/plugin/task/pytorch/GitProjectManager.java
Outdated
Show resolved
Hide resolved
...-pytorch/src/main/java/org/apache/dolphinscheduler/plugin/task/pytorch/PythonEnvManager.java
Outdated
Show resolved
Hide resolved
...pytorch/src/main/java/org/apache/dolphinscheduler/plugin/task/pytorch/PytorchParameters.java
Outdated
Show resolved
Hide resolved
...pytorch/src/main/java/org/apache/dolphinscheduler/plugin/task/pytorch/PytorchParameters.java
Outdated
Show resolved
Hide resolved
I used Chinese screenshots in the Chinese document, and the English version of the document used English screenshots. I am not sure we should use English screenshots both in Chinese document and English version. What do you thinks? @SbloodyS @zhongjiajie |
I vaguely remember that what we asked before was to use English screenshots in both Chinese and English documents. Am I mistaken? @zhongjiajie |
+1, it is unnecessary to maintain two set of screenshots with different language. |
Got it. I will fix it. |
fix doc Co-authored-by: Eric Gao <ericgao.apache@gmail.com>
fix doc Co-authored-by: Eric Gao <ericgao.apache@gmail.com>
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Eric Gao <ericgao.apache@gmail.com>
Co-authored-by: Eric Gao <ericgao.apache@gmail.com>
Purpose of the pull request
close: #11497
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md