Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][UI] Fix the preTask options are unavailable when creating a tas… #11501

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

Amy0104
Copy link
Member

@Amy0104 Amy0104 commented Aug 16, 2022

…k in the task definition page.

Purpose of the pull request

This pull request fixes the preTask options are unavailable when creating a task in the task definition page.

Related Issue

#11499

@Amy0104 Amy0104 added bug Something isn't working UI ui and front end related labels Aug 16, 2022
@Amy0104 Amy0104 self-assigned this Aug 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2022

Codecov Report

Merging #11501 (f84b112) into dev (68316f6) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #11501      +/-   ##
============================================
- Coverage     39.37%   39.36%   -0.01%     
- Complexity     4631     4632       +1     
============================================
  Files           987      987              
  Lines         37566    37566              
  Branches       4184     4183       -1     
============================================
- Hits          14790    14788       -2     
- Misses        21226    21227       +1     
- Partials       1550     1551       +1     
Impacted Files Coverage Δ
...r/plugin/task/sqoop/parameter/SqoopParameters.java 55.12% <0.00%> (-1.29%) ⬇️
...pache/dolphinscheduler/common/utils/DateUtils.java 74.37% <0.00%> (-0.63%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@devosend devosend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amy0104 Amy0104 merged commit 182455c into apache:dev Aug 17, 2022
@SbloodyS SbloodyS added this to the 3.0.1 milestone Aug 17, 2022
zhuxt2015 pushed a commit to zhuxt2015/dolphinscheduler that referenced this pull request Aug 21, 2022
@zhuangchong zhuangchong added the release cherry-pick Mark this issue/PR had cherry-pick for release version label Sep 19, 2022
@Amy0104 Amy0104 deleted the fix/11499 branch September 23, 2022 09:17
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release cherry-pick Mark this issue/PR had cherry-pick for release version UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants