Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logger header in task log file #11555

Merged

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Aug 19, 2022

Purpose of the pull request

In task log file, we don't care about the thread name and line, we only want to see the log message.

image

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2022

Codecov Report

Merging #11555 (2f8aeef) into dev (8b3f60e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev   #11555   +/-   ##
=========================================
  Coverage     39.66%   39.66%           
+ Complexity     4697     4695    -2     
=========================================
  Files           993      993           
  Lines         37695    37695           
  Branches       4198     4199    +1     
=========================================
+ Hits          14950    14953    +3     
+ Misses        21176    21173    -3     
  Partials       1569     1569           
Impacted Files Coverage Δ
...erver/master/processor/queue/TaskEventService.java 80.35% <0.00%> (+5.35%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ruanwenjun ruanwenjun added this to the 3.0.1 milestone Aug 19, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ruanwenjun ruanwenjun merged commit 3516533 into apache:dev Aug 19, 2022
@ruanwenjun ruanwenjun deleted the dev_wenjun_removeLogHeaderInTaskLog branch August 19, 2022 06:01
zhuxt2015 pushed a commit to zhuxt2015/dolphinscheduler that referenced this pull request Aug 21, 2022
zhuangchong pushed a commit to zhuangchong/incubator-dolphinscheduler that referenced this pull request Sep 15, 2022
@zhuangchong zhuangchong added the release cherry-pick Mark this issue/PR had cherry-pick for release version label Sep 15, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend release cherry-pick Mark this issue/PR had cherry-pick for release version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants