Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix homepage email subscription link #11622

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Fix homepage email subscription link #11622

merged 2 commits into from
Aug 24, 2022

Conversation

EricGao888
Copy link
Member

Purpose of the pull request

Brief change log

  • Already described above.

Verify this pull request

  • This is a doc fix.

@EricGao888 EricGao888 marked this pull request as ready for review August 23, 2022 13:19
@EricGao888 EricGao888 self-assigned this Aug 23, 2022
@SbloodyS SbloodyS added this to the 3.0.1 milestone Aug 24, 2022
SbloodyS
SbloodyS approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SbloodyS SbloodyS added the bug Something isn't working label Aug 24, 2022
@EricGao888 EricGao888 merged commit 3e73829 into apache:dev Aug 24, 2022
@EricGao888
Copy link
Member Author

Seems it hasn't taken effect yet. May I ask whether there is anything else I need to change to fix homepage email subscription link? @SbloodyS @zhongjiajie

@SbloodyS
Copy link
Member

Seems it hasn't taken effect yet. May I ask whether there is anything else I need to change to fix homepage email subscription link? @SbloodyS @zhongjiajie

It has taken effect now. The documents of the current dev branch are regularly triggered to build the official website, which is different from the dolphinscheduler-website repository.

zhongjiajie pushed a commit that referenced this pull request Sep 17, 2022
@EricGao888 @zhongjiajie
Fix homepage email subscription link (#11622)
11b78a8 
* Fix homepage email link bug

* Replace dev with latest

(cherry picked from commit 3e73829)
@zhongjiajie zhongjiajie added the release cherry-pick Mark this issue/PR had cherry-pick for release version label Sep 17, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
@EricGao888 @xdu-chenrj
Fix homepage email subscription link (apache#11622)
c42d62a 
* Fix homepage email link bug

* Replace dev with latest
@William-GuoWei William-GuoWei mentioned this pull request Nov 5, 2022
Open
@William-GuoWei William-GuoWei mentioned this pull request Dec 26, 2022
Open
@William-GuoWei William-GuoWei mentioned this pull request Nov 27, 2023
Open
@William-GuoWei William-GuoWei mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SbloodyS SbloodyS SbloodyS approved these changes

@zhongjiajie zhongjiajie Awaiting requested review from zhongjiajie

@Tianqi-Dotes Tianqi-Dotes Awaiting requested review from Tianqi-Dotes

Assignees

@EricGao888 EricGao888

Labels
bug Something isn't working document release cherry-pick Mark this issue/PR had cherry-pick for release version
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@EricGao888 @SbloodyS @zhongjiajie