Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][UI] Fix bug where crontab special of month and year #11661

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

devosend
Copy link
Contributor

Purpose of the pull request

close #11426

Brief change log

image

## Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@devosend devosend added bug Something isn't working UI ui and front end related labels Aug 26, 2022
@devosend devosend added this to the 3.0.1 milestone Aug 26, 2022
@devosend devosend self-assigned this Aug 26, 2022
@devosend devosend requested a review from Amy0104 as a code owner August 26, 2022 08:02
Copy link
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2022

Codecov Report

Merging #11661 (69f8576) into dev (cf3b442) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #11661      +/-   ##
============================================
- Coverage     39.84%   39.81%   -0.04%     
- Complexity     4710     4720      +10     
============================================
  Files           996     1002       +6     
  Lines         37760    37872     +112     
  Branches       4208     4229      +21     
============================================
+ Hits          15046    15079      +33     
- Misses        21145    21192      +47     
- Partials       1569     1601      +32     
Impacted Files Coverage Δ
...ler/server/worker/metrics/WorkerServerMetrics.java 0.00% <0.00%> (-74.47%) ⬇️
...ache/dolphinscheduler/plugin/task/dvc/DvcTask.java 67.16% <0.00%> (-5.42%) ⬇️
...phinscheduler/plugin/task/pytorch/PytorchTask.java 49.01% <0.00%> (-5.33%) ⬇️
...lphinscheduler/plugin/task/emr/EmrJobFlowTask.java 77.77% <0.00%> (-4.58%) ⬇️
...phinscheduler/plugin/task/jupyter/JupyterTask.java 67.34% <0.00%> (-3.63%) ⬇️
...phinscheduler/plugin/task/emr/EmrAddStepsTask.java 64.51% <0.00%> (-3.29%) ⬇️
...olphinscheduler/plugin/task/mlflow/MlflowTask.java 57.54% <0.00%> (-2.85%) ⬇️
...olphinscheduler/plugin/task/pigeon/PigeonTask.java 56.52% <0.00%> (-0.36%) ⬇️
...uler/server/worker/runner/WorkerManagerThread.java 0.00% <0.00%> (ø)
...ler/server/worker/processor/TaskKillProcessor.java 0.00% <0.00%> (ø)
... and 18 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Aug 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@devosend devosend merged commit 769a20e into apache:dev Aug 26, 2022
fengjian1129 pushed a commit to fengjian1129/dolphinscheduler that referenced this pull request Sep 13, 2022
zhuangchong pushed a commit to zhuangchong/incubator-dolphinscheduler that referenced this pull request Sep 17, 2022
@zhuangchong zhuangchong added the release cherry-pick Mark this issue/PR had cherry-pick for release version label Sep 17, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release cherry-pick Mark this issue/PR had cherry-pick for release version UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [crontab] The maximum value of hour selection is 59
5 participants