Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix-11877][UI] Fix the problem that the environment cannot be deleted on the UI of some tasks #11878

Merged
merged 1 commit into from
Sep 13, 2022
Merged

[Fix-11877][UI] Fix the problem that the environment cannot be deleted on the UI of some tasks #11878

merged 1 commit into from
Sep 13, 2022

Conversation

rickchengx
Copy link
Contributor

Purpose of the pull request

close: #11877

Environment cannot be removed on the ui of some task plugins

  1. Create an environment called test.
  2. Create a workflow and create a task (E.g., PYTHON task) and remove the environment on the ui

截屏2022-09-09 14 25 18

  1. Save the workflow
  2. Reopen the created workflow and find that the environment is still there and cannot be removed

截屏2022-09-09 14 26 07

Brief change log

change Fields.useEnvironmentName(model, !model.id) to Fields.useEnvironmentName(model, !data?.id)

Verify this pull request

manually tested

@github-actions github-actions bot added the UI ui and front end related label Sep 9, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SbloodyS SbloodyS added the bug Something isn't working label Sep 9, 2022
@SbloodyS SbloodyS added this to the 3.0.1 milestone Sep 9, 2022
Amy0104
Amy0104 approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amy0104 Amy0104 merged commit 120d8f6 into apache:dev Sep 13, 2022
@zhuangchong zhuangchong mentioned this pull request Sep 14, 2022
Merged
@zhuangchong zhuangchong added the release cherry-pick Mark this issue/PR had cherry-pick for release version label Sep 15, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Sep 17, 2022
@rickchengx @xdu-chenrj
[Fix-11877][UI] Fix the problem that the environment cannot be delete…
167e72e 
…d on the UI of some tasks (apache#11878)
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
@rickchengx @xdu-chenrj
[Fix-11877][UI] Fix the problem that the environment cannot be delete…
d8264cb 
…d on the UI of some tasks (apache#11878)
@zhuangchong zhuangchong modified the milestones: 3.0.1, 3.1.8 Jul 20, 2023
@zhuangchong zhuangchong added the 3.1.x for 3.1.x version label Jul 20, 2023
zhuangchong pushed a commit that referenced this pull request Jul 20, 2023
@rickchengx @zhuangchong
cherry-pick [Fix-11877][UI] Fix the problem that the environment cann…
64b9200 
…ot be deleted on the UI of some tasks

#11878
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amy0104 Amy0104 Amy0104 approved these changes

@songjianet songjianet Awaiting requested review from songjianet songjianet is a code owner

@labbomb labbomb Awaiting requested review from labbomb

@devosend devosend Awaiting requested review from devosend

Assignees

@rickchengx rickchengx

Labels
3.1.x for 3.1.x version bug Something isn't working release cherry-pick Mark this issue/PR had cherry-pick for release version UI ui and front end related
Projects
None yet
Milestone
3.1.8
Development

Successfully merging this pull request may close these issues.

[Bug] [UI] Environment cannot be removed on the ui of some task plugins
4 participants
@rickchengx @Amy0104 @SbloodyS @zhuangchong