Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][PyDolphinScheduler] Add Sagemaker YAML example define in pyds #11925

Merged
merged 1 commit into from
Sep 17, 2022

Conversation

jieguangzhou
Copy link
Member

Purpose of the pull request

close: #11921

Brief change log

  • add YAML example
  • Add the document
#Define the workflow
workflow:
  name: "Sagemaker"
  release_state: "offline"

# Define the tasks under the process
tasks:
  - name: sagemaker
    task_type: Sagemaker
    sagemaker_request_json: $FILE{"example_sagemaker_params.json"}

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2022

Codecov Report

Merging #11925 (d551b38) into dev (864a908) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #11925      +/-   ##
============================================
- Coverage     38.69%   38.66%   -0.03%     
+ Complexity     3999     3998       -1     
============================================
  Files          1003     1003              
  Lines         36559    36559              
  Branches       4222     4222              
============================================
- Hits          14145    14137       -8     
- Misses        20808    20817       +9     
+ Partials       1606     1605       -1     
Impacted Files Coverage Δ
...eduler/server/worker/task/WorkerHeartBeatTask.java 69.38% <0.00%> (-8.17%) ⬇️
...erver/master/processor/queue/TaskEventService.java 75.00% <0.00%> (-5.36%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 55.12% <0.00%> (-1.29%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jieguangzhou
Copy link
Member Author

@zhongjiajie PTAL, thanks

zhongjiajie
zhongjiajie previously approved these changes Sep 16, 2022
Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

@zhongjiajie
Copy link
Member

waiting for CI

@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jieguangzhou
Copy link
Member Author

@zhongjiajie PTAL, thanks

@zhongjiajie zhongjiajie merged commit e05f14b into apache:dev Sep 17, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Sep 17, 2022
zhongjiajie pushed a commit that referenced this pull request Sep 18, 2022
@caishunfeng caishunfeng added the release cherry-pick Mark this issue/PR had cherry-pick for release version label Sep 19, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document feature new feature Python release cherry-pick Mark this issue/PR had cherry-pick for release version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][PyDolphinScheduler] Support SageMaker task in pyds
5 participants