-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][PyDolphinScheduler] Add Sagemaker YAML example define in pyds #11925
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #11925 +/- ##
============================================
- Coverage 38.69% 38.66% -0.03%
+ Complexity 3999 3998 -1
============================================
Files 1003 1003
Lines 36559 36559
Branches 4222 4222
============================================
- Hits 14145 14137 -8
- Misses 20808 20817 +9
+ Partials 1606 1605 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@zhongjiajie PTAL, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
waiting for CI |
0255214
to
acddb57
Compare
acddb57
to
d551b38
Compare
Kudos, SonarCloud Quality Gate passed! |
@zhongjiajie PTAL, thanks |
(cherry picked from commit e05f14b)
Purpose of the pull request
close: #11921
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)