Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix-11321][ui] fix create workflow contains chunjun node failed #11979

Merged
merged 1 commit into from
May 22, 2023
Merged

[fix-11321][ui] fix create workflow contains chunjun node failed #11979

merged 1 commit into from
May 22, 2023

Conversation

jkhhuse
Copy link
Contributor

@jkhhuse jkhhuse commented Sep 16, 2022

  • set customConfig default value as true

This closes #11321

Purpose of the pull request
fix create workflow contains chunjun node failed bug, and set customConfig default value as true.

Verify this pull request
This pull request is code cleanup without any test coverage.

@jkhhuse
[fix-11321][ui] fix create workflow contains chunjun node failed
5062324 
- set customConfig default value as true

This closes apache#11321
@github-actions github-actions bot added the UI ui and front end related label Sep 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2022 •
edited
Loading

Codecov Report

Merging #11979 (07b4955) into dev (86291bb) will decrease coverage by 0.31%.
The diff coverage is n/a.

❗ Current head 07b4955 differs from pull request most recent head 5062324. Consider uploading reports for the commit 5062324 to get more accurate results

@@             Coverage Diff              @@
##                dev   #11979      +/-   ##
============================================
- Coverage     38.70%   38.40%   -0.31%     
- Complexity     4064     4455     +391     
============================================
  Files          1005     1223     +218     
  Lines         36792    42541    +5749     
  Branches       4279     4717     +438     
============================================
+ Hits          14240    16336    +2096     
- Misses        20927    24405    +3478     
- Partials       1625     1800     +175

see 1063 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SbloodyS SbloodyS added the bug Something isn't working label Sep 16, 2022
@SbloodyS SbloodyS added this to the 3.0.1 milestone Sep 16, 2022
@zhuangchong zhuangchong modified the milestones: 3.0.1, 3.0.2 Sep 17, 2022
@jkhhuse
Copy link
Contributor Author

jkhhuse commented Oct 21, 2022

@songjianet I just commit one line of ui code, why the checks can't pass？need a help.

@EricGao888 EricGao888 modified the milestones: 3.0.2, 3.0.3 Nov 7, 2022
@zhongjiajie
Copy link
Member

@jkhhuse could you try to rebase on upstream/dev, and try again?

@songjianet I just commit one line of ui code, why the checks can't pass？need a help.

@zhongjiajie zhongjiajie modified the milestones: 3.0.3, 3.0.4 Dec 19, 2022
@zhongjiajie zhongjiajie modified the milestones: 3.0.4, 3.0.5 Dec 29, 2022
@jieguangzhou jieguangzhou added the 3.1.x for 3.1.x version label Jan 6, 2023
@jieguangzhou
Copy link
Member

This pr can fix the Chunjun task plugin temporarily.

But we have to optimize this task plugin in the future because many parameters in the backend can not define in the Front end, such as

image

@jieguangzhou
Copy link
Member

@jkhhuse can you rebase the dev and then the CI will be restarted

jieguangzhou
jieguangzhou approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@jieguangzhou jieguangzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongjiajie zhongjiajie modified the milestones: 3.0.5, 3.1.5 Mar 30, 2023
@zhuangchong zhuangchong reopened this Mar 30, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zhuangchong zhuangchong modified the milestones: 3.1.5, 3.1.6 Mar 30, 2023
@zhuangchong zhuangchong modified the milestones: 3.1.6, 3.1.7 May 10, 2023
@zhuangchong zhuangchong reopened this May 22, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented May 22, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@zhuangchong zhuangchong merged commit 9979ea3 into apache:dev May 22, 2023
zhuangchong pushed a commit that referenced this pull request May 22, 2023
@jkhhuse @zhuangchong
[fix-11321][ui] fix create workflow contains chunjun node failed (#11979
05ebd40 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieguangzhou jieguangzhou jieguangzhou approved these changes

@songjianet songjianet Awaiting requested review from songjianet songjianet is a code owner

@Amy0104 Amy0104 Awaiting requested review from Amy0104

Assignees

@jkhhuse jkhhuse

Labels
3.1.x for 3.1.x version bug Something isn't working priority:low UI ui and front end related
Projects
None yet
Milestone
3.1.7
Development

Successfully merging this pull request may close these issues.

[Bug] [UI] create workflow contains chunjun node failed
7 participants
@jkhhuse @codecov-commenter @zhongjiajie @jieguangzhou @SbloodyS @EricGao888 @zhuangchong