Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][Test] Remove powermock in dolphinscheduler-master module #12143

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

EricGao888
Copy link
Member

@EricGao888 EricGao888 commented Sep 26, 2022

Purpose of the pull request

Brief change log

This PR did some code cleaning In dolphinscheduler-master module:

  • Removed powermock related code.
  • Removed redundant comments and useless test code.
  • Removed unnecessary stubbings.

Verify this pull request

  • Covered and verified by unit tests.

…comments, useless code and unnecessary stubbings
@EricGao888 EricGao888 self-assigned this Sep 26, 2022
@EricGao888 EricGao888 added improvement make more easy to user or prompt friendly test labels Sep 26, 2022
@github-actions github-actions bot added backend and removed test labels Sep 26, 2022
@EricGao888 EricGao888 added this to the 3.2.0 milestone Sep 26, 2022
@EricGao888 EricGao888 marked this pull request as ready for review September 26, 2022 07:19
@codecov-commenter
Copy link

Codecov Report

Merging #12143 (4fce2a0) into dev (6eb1eb7) will increase coverage by 0.35%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #12143      +/-   ##
============================================
+ Coverage     38.69%   39.04%   +0.35%     
- Complexity     4010     4078      +68     
============================================
  Files          1001     1010       +9     
  Lines         37422    37713     +291     
  Branches       4262     4330      +68     
============================================
+ Hits          14480    14726     +246     
- Misses        21295    21299       +4     
- Partials       1647     1688      +41     
Impacted Files Coverage Δ
...scheduler/api/service/impl/FavTaskServiceImpl.java 5.88% <0.00%> (-3.21%) ⬇️
...apache/dolphinscheduler/common/utils/NetUtils.java 49.28% <0.00%> (-1.07%) ⬇️
...uler/server/master/registry/ServerNodeManager.java 1.05% <0.00%> (-0.13%) ⬇️
.../org/apache/dolphinscheduler/api/enums/Status.java 100.00% <0.00%> (ø)
.../org/apache/dolphinscheduler/api/utils/Result.java 94.11% <0.00%> (ø)
.../org/apache/dolphinscheduler/spi/enums/DbType.java 0.00% <0.00%> (ø)
...eduler/api/dto/schedule/ScheduleCreateRequest.java 85.71% <0.00%> (ø)
...eduler/api/dto/schedule/ScheduleUpdateRequest.java 41.66% <0.00%> (ø)
...eduler/api/dto/workflow/WorkflowCreateRequest.java 100.00% <0.00%> (ø)
...eduler/api/dto/workflow/WorkflowUpdateRequest.java 50.00% <0.00%> (ø)
... and 16 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@EricGao888 EricGao888 merged commit cc82206 into apache:dev Sep 26, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
* Remove powermock related code in dolphinscheduler-master module
* Remove redundant comments, useless code and unnecessary stubbings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend improvement make more easy to user or prompt friendly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement][Test] Remove Powermock in dolphinscheduler-master
3 participants