-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement][Test] Block the usage of powermock and move mockito dependencies from sub-modules to root pom #12311
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #12311 +/- ##
============================================
- Coverage 38.62% 38.60% -0.02%
- Complexity 4101 4104 +3
============================================
Files 1031 1031
Lines 38459 38459
Branches 4404 4402 -2
============================================
- Hits 14854 14848 -6
- Misses 21872 21881 +9
+ Partials 1733 1730 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Currently we use Lines 679 to 686 in 04e1b88
dolphinscheduler/.pre-commit-config.yaml Lines 58 to 65 in 04e1b88
I'm thinking about changing the WDYT @kezhenxu94 @zhongjiajie |
Sounds good to me |
+1 for me |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
PTAL when available, thx~ @kezhenxu94 @caishunfeng @ruanwenjun @SbloodyS @zhongjiajie |
…endencies from sub-modules to root pom (apache#12311) * move mockito dependencies from sub-modules to root pom * Add check in CI to block the usage of powermock
Purpose of the pull request
Powermock
#11637Brief change log
Spotless
to block the usage of powermock .Verify this pull request