Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alert status spelling error #12592

Merged
merged 2 commits into from
Oct 29, 2022
Merged

Fix alert status spelling error #12592

merged 2 commits into from
Oct 29, 2022

Conversation

qingwli
Copy link
Member

@qingwli qingwli commented Oct 28, 2022

PLUGIN_INSTANCE_ALREADY_EXIT spelling error, change to PLUGIN_INSTANCE_ALREADY_EXISTS

@SbloodyS SbloodyS added this to the 3.0.2 milestone Oct 28, 2022
@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Oct 28, 2022
SbloodyS
SbloodyS previously approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

caishunfeng
caishunfeng previously approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@caishunfeng caishunfeng added 3.0.x 3.1.x for 3.1.x version labels Oct 28, 2022
@qingwli qingwli dismissed stale reviews from caishunfeng and SbloodyS via 3000893 October 28, 2022 13:10
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022 •
edited
Loading

Codecov Report

Merging #12592 (3000893) into dev (0c519f7) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                dev   #12592      +/-   ##
============================================
- Coverage     39.12%   39.11%   -0.02%     
+ Complexity     4192     4190       -2     
============================================
  Files          1044     1044              
  Lines         39447    39447              
  Branches       4530     4530              
============================================
- Hits          15434    15430       -4     
- Misses        22259    22265       +6     
+ Partials       1754     1752       -2
Impacted Files Coverage Δ
.../api/controller/AlertPluginInstanceController.java 100.00% <100.00%> (ø)
.../org/apache/dolphinscheduler/api/enums/Status.java 100.00% <100.00%> (ø)
...i/service/impl/AlertPluginInstanceServiceImpl.java 63.86% <100.00%> (ø)
...org/apache/dolphinscheduler/remote/utils/Host.java 42.55% <0.00%> (-2.13%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 51.38% <0.00%> (-1.39%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 51.19% <0.00%> (-1.20%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@EricGao888 EricGao888 merged commit fb9761f into apache:dev Oct 29, 2022
zhuangchong pushed a commit that referenced this pull request Oct 29, 2022
@qingwli @zhuangchong
cherry-pick Fix alert status spelling error
5eaf105 
#12592
@qingwli qingwli deleted the fix-spelling-error branch October 31, 2022 01:57
hstdream pushed a commit to hstdream/dolphinscheduler that referenced this pull request Nov 2, 2022
@qingwli
Fix alert status spelling error (apache#12592)
dd18574 
* fix alert status spelling error

* fix-ut
hstdream pushed a commit to hstdream/dolphinscheduler that referenced this pull request Nov 2, 2022
Revert "Fix alert status spelling error (apache#12592)"
3d344fc 
This reverts commit dd18574.
@EricGao888 EricGao888 modified the milestones: 3.0.2, 3.2.0 Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkAssassinator DarkAssassinator DarkAssassinator requested changes

@zhuangchong zhuangchong zhuangchong approved these changes

@EricGao888 EricGao888 EricGao888 approved these changes

@SbloodyS SbloodyS SbloodyS left review comments

@caishunfeng caishunfeng caishunfeng left review comments

Assignees

@qingwli qingwli

Labels
3.1.x for 3.1.x version backend improvement make more easy to user or prompt friendly
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
7 participants
@qingwli @codecov-commenter @caishunfeng @SbloodyS @DarkAssassinator @EricGao888 @zhuangchong