[Feature][DataSource]Add trino datasource plugin #12911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insist777
requested review from
kezhenxu94,
songjianet,
Amy0104 and
caishunfeng
as code owners
insist777
changed the title
dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-trino/pom.xml
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/dolphinscheduler/plugin/datasource/trino/param/TrinoConnectionParam.java
Outdated
Show resolved
Hide resolved
...java/org/apache/dolphinscheduler/plugin/datasource/trino/param/TrinoDataSourceProcessor.java
Outdated
Show resolved
Hide resolved
...java/org/apache/dolphinscheduler/plugin/datasource/trino/param/TrinoDataSourceProcessor.java
Outdated
Show resolved
Hide resolved
...est/java/org/apache/dolphinscheduler/plugin/datasource/trino/TrinoDataSourceChannelTest.java
Outdated
Show resolved
Hide resolved
|
@insist777 please run |
ruanwenjun
reviewed
Nov 16, 2022
dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/enums/DbType.java
Outdated
Show resolved
Hide resolved
dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-trino/pom.xml
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## dev #12911 +/- ##
============================================
- Coverage 39.44% 39.36% -0.09%
- Complexity 4244 4269 +25
============================================
Files 1052 1067 +15
Lines 39859 40116 +257
Branches 4586 4606 +20
============================================
+ Hits 15722 15790 +68
- Misses 22359 22549 +190
+ Partials 1778 1777 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...java/org/apache/dolphinscheduler/plugin/datasource/trino/param/TrinoDataSourceProcessor.java
Fixed
Show fixed
Hide fixed
...java/org/apache/dolphinscheduler/plugin/datasource/trino/param/TrinoDataSourceProcessor.java
Fixed
Show resolved
Hide resolved
insist777
requested review from
DarkAssassinator
and removed request for
caishunfeng,
kezhenxu94,
songjianet and
Amy0104
insist777
requested review from
ruanwenjun and
DarkAssassinator
and removed request for
DarkAssassinator and
ruanwenjun
insist777
requested review from
zhongjiajie,
Tianqi-Dotes and
EricGao888
as code owners
...java/org/apache/dolphinscheduler/plugin/datasource/trino/param/TrinoDataSourceProcessor.java
Fixed
Show fixed
Hide fixed
SbloodyS
changed the title
...java/org/apache/dolphinscheduler/plugin/datasource/trino/param/TrinoDataSourceProcessor.java
Fixed
Show fixed
Hide fixed
...java/org/apache/dolphinscheduler/plugin/datasource/trino/param/TrinoDataSourceProcessor.java
Fixed
Show fixed
Hide fixed
| TrinoDataSourceParamDTO TrinoDatasourceParamDTO = new TrinoDataSourceParamDTO(); | ||
| String[] split = hostPortArray[0].split(Constants.COLON); | ||
| TrinoDatasourceParamDTO.setHost(split[0]); | ||
| TrinoDatasourceParamDTO.setPort(Integer.valueOf(split[1])); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Brief change log
Add trino data source plugin, version 402.
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md