Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Python gateway can not upload to resource center #13042

Merged
merged 2 commits into from
Dec 2, 2022

Conversation

zhongjiajie
Copy link
Member

in #12076 we refactor our resource center, remove the resource table, it is a good refactor but it failed python api upload, this patch try to fix python api upload function

ref: #12076

in apache#12076 we refactor our resource center, remove the resource table,
it is a good refactor but it failed python api upload, this patch try
to fix python api upload function

ref: apache#12076
@zhongjiajie zhongjiajie self-assigned this Nov 29, 2022
@zhongjiajie zhongjiajie added the 3.2.0 for 3.2.0 version label Nov 29, 2022
@mergeable mergeable bot removed backend 3.2.0 for 3.2.0 version labels Nov 29, 2022
@zhongjiajie zhongjiajie added this to the 3.2.0 milestone Nov 29, 2022
@zhongjiajie zhongjiajie marked this pull request as draft November 29, 2022 07:46
@zhongjiajie zhongjiajie added the 3.2.0 for 3.2.0 version label Nov 29, 2022
@SbloodyS SbloodyS added the feature new feature label Nov 29, 2022
@zhongjiajie zhongjiajie added bug Something isn't working and removed feature new feature labels Nov 29, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2022

Codecov Report

Merging #13042 (8148bfd) into dev (e180e16) will decrease coverage by 0.03%.
The diff coverage is 69.23%.

@@             Coverage Diff              @@
##                dev   #13042      +/-   ##
============================================
- Coverage     39.36%   39.33%   -0.04%     
+ Complexity     4273     4271       -2     
============================================
  Files          1067     1069       +2     
  Lines         40121    40135      +14     
  Branches       4601     4602       +1     
============================================
- Hits          15793    15786       -7     
- Misses        22551    22573      +22     
+ Partials       1777     1776       -1     
Impacted Files Coverage Δ
...heduler/api/service/impl/ResourcesServiceImpl.java 38.65% <63.63%> (+0.03%) ⬆️
...che/dolphinscheduler/api/python/PythonGateway.java 17.93% <100.00%> (ø)
...r/api/service/impl/ProcessInstanceServiceImpl.java 63.96% <0.00%> (-6.42%) ⬇️
...erver/master/processor/queue/TaskEventService.java 75.00% <0.00%> (-5.36%) ⬇️
...erver/worker/runner/WorkerTaskExecuteRunnable.java 38.51% <0.00%> (-1.23%) ⬇️
...cheduler/api/service/impl/ExecutorServiceImpl.java 43.40% <0.00%> (-0.34%) ⬇️
.../server/master/runner/WorkflowExecuteRunnable.java 8.16% <0.00%> (-0.01%) ⬇️
...e/dolphinscheduler/dao/entity/ProcessInstance.java 0.00% <0.00%> (ø)
...cheduler/server/master/utils/DependentExecute.java 0.00% <0.00%> (ø)
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Nov 29, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 5 Code Smells

73.3% 73.3% Coverage
0.0% 0.0% Duplication

@zhongjiajie zhongjiajie marked this pull request as ready for review November 29, 2022 09:31
zhongjiajie added a commit to zhongjiajie/dolphinscheduler-sdk-python that referenced this pull request Nov 29, 2022
* Fix resource upload function related to apache/dolphinscheduler#12076
* And some documentation about how to use resource uploading

ref: apache/dolphinscheduler#13042
zhongjiajie added a commit to zhongjiajie/dolphinscheduler-sdk-python that referenced this pull request Nov 29, 2022
* Fix resource upload function related to apache/dolphinscheduler#12076
* And some documentation about how to use resource uploading

ref: apache/dolphinscheduler#13042

[run-it]
zhongjiajie added a commit that referenced this pull request Nov 29, 2022
@zhongjiajie zhongjiajie merged commit f5a5998 into apache:dev Dec 2, 2022
@zhongjiajie zhongjiajie deleted the f-py-upload-resource branch December 2, 2022 02:12
shangeyao pushed a commit to shangeyao/dolphinscheduler that referenced this pull request Dec 3, 2022
in apache#12076 we refactor our resource center, remove the resource table,
it is a good refactor but it failed python api upload, this patch try
to fix python api upload function

ref: apache#12076
zhongjiajie added a commit to zhongjiajie/dolphinscheduler-sdk-python that referenced this pull request Dec 4, 2022
zhongjiajie added a commit to zhongjiajie/dolphinscheduler-sdk-python that referenced this pull request Dec 4, 2022
zhongjiajie added a commit to zhongjiajie/dolphinscheduler-sdk-python that referenced this pull request Dec 5, 2022
zhongjiajie added a commit to zhongjiajie/dolphinscheduler-sdk-python that referenced this pull request Dec 8, 2022
zhongjiajie added a commit that referenced this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants