[Feature][task-plugins-12820] azure azure-sql datasource plugins #13209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tianqi-Dotes
requested review from
kezhenxu94 and
caishunfeng
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| azureSQLDatasourceParamDTO.setDatabase(connectionParams.getDatabase()); | ||
| azureSQLDatasourceParamDTO.setUserName(connectionParams.getUser()); | ||
| azureSQLDatasourceParamDTO.setOther(connectionParams.getOther()); | ||
| azureSQLDatasourceParamDTO.setPort(Integer.parseInt(hostPortArray[0].split(Constants.COLON)[1])); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException
Codecov Report
@@ Coverage Diff @@
## dev #13209 +/- ##
============================================
+ Coverage 39.35% 39.40% +0.05%
- Complexity 4276 4313 +37
============================================
Files 1067 1077 +10
Lines 40491 40814 +323
Branches 4662 4683 +21
============================================
+ Hits 15934 16082 +148
- Misses 22770 22939 +169
- Partials 1787 1793 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
caishunfeng
previously approved these changes
Dec 18, 2022
...rg/apache/dolphinscheduler/plugin/datasource/azuresql/param/AzureSQLDataSourceProcessor.java
Outdated
Show resolved
Hide resolved
|
@Tianqi-Dotes please add the UI and doc too. |
|
Need to do code format. |
|
|
SonarCloud Quality Gate failed. |
caishunfeng
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
#12820
supports 5 auth mode to azure sql
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md