Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Remove tenant arg in workflow definition #13212

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

zhongjiajie
Copy link
Member

@zhongjiajie zhongjiajie commented Dec 17, 2022

current tenant in workflow only work when the first time user do not exist, when user change the tenant in workflow but tenant exist, it will be ignore, so we try to remove it from workflow, and in apache/dolphinscheduler-sdk-python#40 we try to create both user and tenant vis cli instead of auto create

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2022

Codecov Report

Merging #13212 (2f25ecb) into dev (4b980ad) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev   #13212      +/-   ##
============================================
- Coverage     39.41%   39.39%   -0.03%     
+ Complexity     4316     4315       -1     
============================================
  Files          1077     1077              
  Lines         40814    40818       +4     
  Branches       4683     4680       -3     
============================================
- Hits          16086    16079       -7     
- Misses        22934    22946      +12     
+ Partials       1794     1793       -1     
Impacted Files Coverage Δ
...che/dolphinscheduler/api/python/PythonGateway.java 17.62% <0.00%> (-0.32%) ⬇️
...erver/master/processor/queue/TaskEventService.java 75.00% <0.00%> (-5.36%) ⬇️
...org/apache/dolphinscheduler/remote/utils/Host.java 42.55% <0.00%> (-2.13%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 51.38% <0.00%> (-0.70%) ⬇️
...pache/dolphinscheduler/common/utils/DateUtils.java 68.30% <0.00%> (-0.55%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhongjiajie zhongjiajie added bug Something isn't working 3.1.x for 3.1.x version labels Dec 19, 2022
current tenant in workflow only work when the first time
user do not exist, when user change the tenant in workflow
but tenant exist, it will be ignore, so we try to remove it
from workflow, and in apache#40 we try to create both user and tenant
vis cli instead of auto create
@zhongjiajie zhongjiajie marked this pull request as ready for review December 19, 2022 08:00
@sonarcloud
Copy link

sonarcloud bot commented Dec 19, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@jieguangzhou jieguangzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongjiajie zhongjiajie merged commit 5cd8a02 into apache:dev Dec 19, 2022
@zhongjiajie zhongjiajie deleted the i-py-rm-tenant-simple branch December 19, 2022 08:06
zhongjiajie added a commit that referenced this pull request Mar 23, 2023
current tenant in workflow only work when the first time
user do not exist, when user change the tenant in workflow
but tenant exist, it will be ignore, so we try to remove it
from workflow, and in #40 we try to create both user and tenant
vis cli instead of auto create
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.1.x for 3.1.x version backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants