-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement][Deployment] Use minio as defaut storage if deployed in k8s #13372
Conversation
Seems the version and app version of DS helm chart is still dolphinscheduler/deploy/kubernetes/dolphinscheduler/Chart.yaml Lines 34 to 43 in dd0d730
|
good catch, I think we should change to the latest version, could you please also change our release docs to tell release manager change it during the release process? |
Sure, will do : ) |
BTW, find flake dead link https://codecov.io/gh/apache/dolphinscheduler/branch/dev, could you also change url to https://app.codecov.io/gh/apache/dolphinscheduler/tree/dev? |
Sure, will fix it in this PR. |
This reminds me we should also update the release doc to help release manager to also publish the helm chart so that users don't need to download the source codes in order to deploy with Helm Chart. FYI the helm chart repo is here https://hub.docker.com/r/apache/dolphinscheduler-helm/tags Let me write up the release doc to include guide how to release the Helm Chart. |
is there any guide about how to release helm chart to docker hub? |
Check this #13385 |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
others LGTM
|
||
# This is the version number of the application being deployed. This version number should be | ||
# incremented each time you make changes to the application. | ||
appVersion: 3.1.0 | ||
appVersion: latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure whether the latest tag work here or not, I think there are some cases chart.yaml in dev branch not work in our latest version? @kezhenxu94 do you have time to take a look?
Purpose of the pull request
minio
as DS default storage when deployed in K8S, in this way, users could use resource center out-of-the-box.Brief change log
Verify this pull request