Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][Deployment] Use minio as defaut storage if deployed in k8s #13372

Closed
wants to merge 2 commits into from

Conversation

EricGao888
Copy link
Member

Purpose of the pull request

  • Set minio as DS default storage when deployed in K8S, in this way, users could use resource center out-of-the-box.

Brief change log

  • Already described above.

Verify this pull request

  • Verified manually.

@EricGao888 EricGao888 added improvement make more easy to user or prompt friendly 3.2.0 for 3.2.0 version labels Jan 11, 2023
@EricGao888 EricGao888 added this to the 3.2.0 milestone Jan 11, 2023
@EricGao888 EricGao888 self-assigned this Jan 11, 2023
@EricGao888 EricGao888 marked this pull request as ready for review January 11, 2023 05:22
@EricGao888
Copy link
Member Author

EricGao888 commented Jan 11, 2023

Seems the version and app version of DS helm chart is still 3.1.0. Should we change it to 3.1.3? cc @zhongjiajie

type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 3.1.0
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 3.1.0

kezhenxu94
kezhenxu94 previously approved these changes Jan 11, 2023
@zhongjiajie
Copy link
Member

Seems the version and app version of DS helm chart is still 3.1.0. Should we change it to 3.1.3? cc @zhongjiajie

type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 3.1.0
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 3.1.0

good catch, I think we should change to the latest version, could you please also change our release docs to tell release manager change it during the release process?

@EricGao888
Copy link
Member Author

Seems the version and app version of DS helm chart is still 3.1.0. Should we change it to 3.1.3? cc @zhongjiajie

type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 3.1.0
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 3.1.0

good catch, I think we should change to the latest version, could you please also change our release docs to tell release manager change it during the release process?

Sure, will do : )

@zhongjiajie
Copy link
Member

@EricGao888
Copy link
Member Author

BTW, find flake dead link https://codecov.io/gh/apache/dolphinscheduler/branch/dev, could you also change url to https://app.codecov.io/gh/apache/dolphinscheduler/tree/dev?

Sure, will fix it in this PR.

@kezhenxu94
Copy link
Member

This reminds me we should also update the release doc to help release manager to also publish the helm chart so that users don't need to download the source codes in order to deploy with Helm Chart. FYI the helm chart repo is here https://hub.docker.com/r/apache/dolphinscheduler-helm/tags

Let me write up the release doc to include guide how to release the Helm Chart.

@zhongjiajie
Copy link
Member

This reminds me we should also update the release doc to help release manager to also publish the helm chart so that users don't need to download the source codes in order to deploy with Helm Chart. FYI the helm chart repo is here https://hub.docker.com/r/apache/dolphinscheduler-helm/tags

Let me write up the release doc to include guide how to release the Helm Chart.

is there any guide about how to release helm chart to docker hub?

@kezhenxu94
Copy link
Member

This reminds me we should also update the release doc to help release manager to also publish the helm chart so that users don't need to download the source codes in order to deploy with Helm Chart. FYI the helm chart repo is here https://hub.docker.com/r/apache/dolphinscheduler-helm/tags
Let me write up the release doc to include guide how to release the Helm Chart.

is there any guide about how to release helm chart to docker hub?

Check this #13385

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others LGTM


# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 3.1.0
appVersion: latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure whether the latest tag work here or not, I think there are some cases chart.yaml in dev branch not work in our latest version? @kezhenxu94 do you have time to take a look?

@EricGao888 EricGao888 closed this Mar 9, 2023
@kezhenxu94 kezhenxu94 deleted the Switch-to-use-minio-as-default-storage-in-k8s branch March 10, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version improvement make more easy to user or prompt friendly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants