[Feature][task]add azure datafactory task type #13417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tianqi-Dotes
requested review from
kezhenxu94,
caishunfeng,
SbloodyS and
zhuangchong
as code owners
3 tasks
SbloodyS
requested changes
Jan 17, 2023
|
still testing |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| List<String> listResourceGroup(User loginUser); | ||
|
|
||
| List<String> listPipeline(User loginUser, String factoryName, String resourceGroupName); |
Check notice
Code scanning / CodeQL
Useless parameter
|
|
||
| List<String> listDataFactory(User loginUser); | ||
|
|
||
| List<String> listResourceGroup(User loginUser); |
Check notice
Code scanning / CodeQL
Useless parameter
|
|
||
| public interface CloudService { | ||
|
|
||
| List<String> listDataFactory(User loginUser); |
Check notice
Code scanning / CodeQL
Useless parameter
EricGao888
reviewed
Jan 17, 2023
...nscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/CloudController.java
Show resolved
Hide resolved
add data factory ui
… feature/datafactory � Conflicts: � dolphinscheduler-bom/pom.xml
Codecov Report
@@ Coverage Diff @@
## dev #13417 +/- ##
============================================
- Coverage 39.56% 39.53% -0.03%
- Complexity 4327 4349 +22
============================================
Files 1084 1095 +11
Lines 40916 41143 +227
Branches 4697 4710 +13
============================================
+ Hits 16187 16266 +79
- Misses 22927 23070 +143
- Partials 1802 1807 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Tianqi-Dotes
requested review from
zhongjiajie,
songjianet and
Amy0104
as code owners
SbloodyS
reviewed
Jan 18, 2023
...ctory/src/main/java/org/apache/dolphinscheduler/plugin/task/datafactory/DatafactoryHook.java
Outdated
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Brief change log
add datafactory task type
#13177
Verify this pull request
#13177
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md