New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flinksql support standalone deploy mode #13495

Merged

davidzollo merged 1 commit into apache:dev from shenyun:feature-flinksql-support-standalone

Feb 5, 2023

Contributor

shenyun commented Feb 2, 2023

Purpose of the pull request

feature flinksql support standalone deploy mode


          feature flinksql support standalone deploy mode

85b22d6

shenyun requested review from songjianet, Amy0104, caishunfeng, SbloodyS and zhuangchong as code owners

February 2, 2023 02:41

github-actions bot added backend UI labels

SbloodyS assigned shenyun

SbloodyS added 3.2.0 feature first time contributor labels

SbloodyS added this to the 3.2.0 milestone

SbloodyS added the miss:docs label

SbloodyS reviewed

View reviewed changes

Member

SbloodyS left a comment

Please add some docs.

codecov-commenter commented Feb 2, 2023 •

edited

Loading

Codecov Report

Merging #13495 (85b22d6) into dev (5fb6035) will increase coverage by 0.00%.
The diff coverage is 33.33%.

@@            Coverage Diff            @@
##                dev   #13495   +/-   ##
=========================================
  Coverage     39.60%   39.61%           
  Complexity     4357     4357           
=========================================
  Files          1097     1097           
  Lines         41164    41169    +5     
  Branches       4716     4717    +1     
=========================================
+ Hits          16305    16310    +5     
+ Misses        23047    23046    -1     
- Partials       1812     1813    +1

Impacted Files	Coverage Δ
...hinscheduler/plugin/task/flink/FlinkArgsUtils.java	`63.90% <0.00%> (-1.21%)`	⬇️
...inscheduler/plugin/task/flink/FlinkDeployMode.java	`100.00% <100.00%> (ø)`
...r/plugin/task/sqoop/parameter/SqoopParameters.java	`51.19% <0.00%> (-1.20%)`	⬇️
...r/plugin/registry/zookeeper/ZookeeperRegistry.java	`50.80% <0.00%> (+0.80%)`	⬆️
...erver/master/processor/queue/TaskEventService.java	`80.35% <0.00%> (+5.35%)`	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sonarcloud bot commented Feb 2, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

72.7% Coverage
0.0% Duplication

Amy0104 reviewed

View reviewed changes

Member

Amy0104 left a comment

The front end part LGTM.

EricGao888 approved these changes

View reviewed changes

Member

EricGao888 left a comment

LGTM, it would be better if u could add a UT case to https://github.com/apache/dolphinscheduler/blob/dev/dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/test/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkArgsUtilsTest.java

ruanwenjun approved these changes

View reviewed changes

Member

ruanwenjun left a comment

+1

ruanwenjun changed the title ~~feature flinksql support standalone deploy mode~~ Flinksql support standalone deploy mode

davidzollo merged commit 8fa90c2 into apache:dev

Contributor

davidzollo commented Feb 5, 2023

thanks for your first contribution, I'm looking forward to your deep participation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Amy0104 Amy0104 left review comments

SbloodyS SbloodyS left review comments

EricGao888 EricGao888 approved these changes

ruanwenjun ruanwenjun approved these changes

songjianet Awaiting requested review from songjianet songjianet is a code owner

caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

zhuangchong Awaiting requested review from zhuangchong

Labels

3.2.0 backend feature first time contributor miss:docs UI