Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix][Data Quality]Dataquality Spark Get Datasource Password Error When Password Has $ #13643

Merged
merged 1 commit into from
Feb 28, 2023
Merged

[Fix][Data Quality]Dataquality Spark Get Datasource Password Error When Password Has $ #13643

merged 1 commit into from
Feb 28, 2023

Conversation

qingwli
Copy link
Member

@qingwli qingwli commented Feb 28, 2023

@SbloodyS SbloodyS added bug Something isn't working 3.1.x for 3.1.x version labels Feb 28, 2023
@SbloodyS SbloodyS added this to the 3.1.5 milestone Feb 28, 2023
SbloodyS
SbloodyS approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023 •
edited
Loading

Codecov Report

Merging #13643 (9b674c4) into dev (c1fd1cb) will increase coverage by 0.03%.
The diff coverage is 90.47%.

❗ Current head 9b674c4 differs from pull request most recent head 17d82d2. Consider uploading reports for the commit 17d82d2 to get more accurate results

@@             Coverage Diff              @@
##                dev   #13643      +/-   ##
============================================
+ Coverage     39.03%   39.07%   +0.03%     
- Complexity     4413     4424      +11     
============================================
  Files          1127     1128       +1     
  Lines         42096    42111      +15     
  Branches       4775     4775              
============================================
+ Hits          16431    16453      +22     
+ Misses        23849    23842       -7     
  Partials       1816     1816
Impacted Files Coverage Δ
...lphinscheduler/data/quality/utils/ParserUtils.java 86.66% <86.66%> (ø)
...ler/data/quality/flow/batch/reader/JdbcReader.java 95.00% <100.00%> (ø)
...ler/data/quality/flow/batch/writer/JdbcWriter.java 85.00% <100.00%> (ø)
...cheduler/plugin/task/dq/utils/RuleParserUtils.java 86.98% <100.00%> (ø)
...erver/master/processor/queue/TaskEventService.java 75.00% <0.00%> (-5.36%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 36.90% <0.00%> (+14.28%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@qingwli
Copy link
Member Author

qingwli commented Feb 28, 2023

Please help re-run https://github.com/apache/dolphinscheduler/actions/runs/4290123834/jobs/7473940180 @SbloodyS

@SbloodyS
Copy link
Member

Please help re-run https://github.com/apache/dolphinscheduler/actions/runs/4290123834/jobs/7473940180 @SbloodyS

Done.

@qingwli
Copy link
Member Author

qingwli commented Feb 28, 2023

Please re-run SonarCloud Code Analysis @SbloodyS

@zixi0825
Copy link
Member

LGTM

@zixi0825 zixi0825 merged commit 43d79e4 into apache:dev Feb 28, 2023
@qingwli qingwli deleted the fix-data-quality-pwd-error branch March 1, 2023 02:02
zhuangchong pushed a commit that referenced this pull request Mar 30, 2023
@qingwli @zhuangchong
cherry-pick [Fix][Data Quality]Dataquality Spark Get Datasource Passw…
76a1a6d 
…ord Error When Password Has $ #13643
@wangbowen1024 wangbowen1024 mentioned this pull request Dec 25, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SbloodyS SbloodyS SbloodyS approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@zhuangchong zhuangchong Awaiting requested review from zhuangchong

Assignees

@qingwli qingwli

Labels
3.1.x for 3.1.x version backend bug Something isn't working
Projects
None yet
Milestone
3.1.5
Development

Successfully merging this pull request may close these issues.

[Bug] [DataQuality] Dataquality Spark Get Datasource Password Error When Password Has $
5 participants
@qingwli @codecov-commenter @SbloodyS @zixi0825 @zhuangchong