Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][plugin] Add snowflake datasource in datasource plugin #13729

Merged
merged 23 commits into from
May 6, 2023
Merged

[Feature][plugin] Add snowflake datasource in datasource plugin #13729

merged 23 commits into from
May 6, 2023

Conversation

zhaohehuhu
Copy link
Contributor

@zhaohehuhu zhaohehuhu commented Mar 13, 2023 •
edited
Loading

Purpose of the pull request

close #13727

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@github-actions github-actions bot added backend document UI ui and front end related labels Mar 13, 2023
@zhaohehuhu zhaohehuhu mentioned this pull request Mar 13, 2023
Merged
@SbloodyS SbloodyS added the feature new feature label Mar 13, 2023
@SbloodyS SbloodyS added this to the 3.2.0 milestone Mar 13, 2023
@SbloodyS SbloodyS added the 3.2.0 for 3.2.0 version label Mar 13, 2023
SbloodyS
SbloodyS reviewed Mar 13, 2023
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the failed CI.

@fuchanghai
Copy link
Member

fuchanghai commented Mar 13, 2023 •
edited
Loading

plz refer to #13727

@zhaohehuhu
Copy link
Contributor Author

plz refer to #13727

got it. will check later

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2023 •
edited
Loading

Codecov Report

Merging #13729 (0f55594) into dev (920e9b8) will increase coverage by 0.08%.
The diff coverage is 79.03%.

❗ Current head 0f55594 differs from pull request most recent head 2da6fd5. Consider uploading reports for the commit 2da6fd5 to get more accurate results

@@             Coverage Diff              @@
##                dev   #13729      +/-   ##
============================================
+ Coverage     38.21%   38.29%   +0.08%     
- Complexity     4440     4465      +25     
============================================
  Files          1222     1228       +6     
  Lines         42759    42820      +61     
  Branches       4745     4748       +3     
============================================
+ Hits          16339    16399      +60     
+ Misses        24613    24612       -1     
- Partials       1807     1809       +2
Impacted Files Coverage Δ
...cheduler/common/constants/DataSourceConstants.java 0.00% <ø> (ø)
...atasource/snowflake/SnowflakeDataSourceClient.java 0.00% <0.00%> (ø)
.../org/apache/dolphinscheduler/spi/enums/DbType.java 0.00% <0.00%> (ø)
...tasource/snowflake/SnowflakeDataSourceChannel.java 50.00% <50.00%> (ø)
.../snowflake/param/SnowflakeDatasourceProcessor.java 83.33% <83.33%> (ø)
...e/snowflake/SnowflakeDataSourceChannelFactory.java 100.00% <100.00%> (ø)
...urce/snowflake/param/SnowflakeConnectionParam.java 100.00% <100.00%> (ø)
...e/snowflake/param/SnowflakeDatasourceParamDTO.java 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fuchanghai
Copy link
Member

plz refer to #13727

got it. will check later

sorry ， l mean that this PR should be associated with issue

@zhaohehuhu
Copy link
Contributor Author

plz refer to #13727

got it. will check later

sorry ， l mean that this PR should be associated with issue

Done

@zhaohehuhu
Copy link
Contributor Author

@SbloodyS plz help run CI

@fuchanghai
Copy link
Member

@zhaohehuhu plz run 'mvn spotless:apply' to format codes

@zhaohehuhu
Merge remote-tracking branch 'ds/dev' into Feature-13727
58e4962 
# Conflicts:
#	docs/configs/docsdev.js
#	dolphinscheduler-bom/pom.xml
#	dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/enums/DbType.java
#	tools/dependencies/known-dependencies.txt
@zhaohehuhu
add UTs
6245e2f
@zhaohehuhu
Copy link
Contributor Author

plz help run CI

@zhaohehuhu plz run 'mvn spotless:apply' to format codes

done. and plz help run CI.

@zhaohehuhu
Copy link
Contributor Author

@fuchanghai @SbloodyS @Radeity Is there anything that need to improve ? Plz help

@Radeity
Copy link
Member

Radeity commented Apr 24, 2023

Basically LGTM, can you leave a blank space on the right of snowflake in Chinese doc?

数据源：选择 SNOWFLAKE 数据源

fuchanghai
fuchanghai previously approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM，on my side

@zhaohehuhu
Copy link
Contributor Author

SNOWFLAKE

done. Thanks

@zhaohehuhu
Copy link
Contributor Author

Basically LGTM，on my side

Thanks

@fuchanghai
Copy link
Member

@zhaohehuhu plz resolve conflicts

@zhaohehuhu
Merge remote-tracking branch 'ds/dev' into Feature-13727
97af859 
# Conflicts:
#	dolphinscheduler-datasource-plugin/pom.xml
#	dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/enums/DbType.java
#	dolphinscheduler-ui/src/service/modules/data-source/types.ts
#	tools/dependencies/known-dependencies.txt
@zhaohehuhu
Copy link
Contributor Author

@zhaohehuhu plz resolve conflicts
done.

@zhaohehuhu
Copy link
Contributor Author

@fuchanghai @Radeity @SbloodyS Is it possible to merge this PR now? Thanks.

@zhaohehuhu
Copy link
Contributor Author

@Radeity @Radeity @SbloodyS Is there anything that needs to get improved ?

SbloodyS
SbloodyS previously approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhongjiajie
Copy link
Member

@zhaohehuhu do you mind solving the conflict? and we will merge ASAP after that

@zhaohehuhu
Merge remote-tracking branch 'ds/dev' into Feature-13727
2da6fd5 
# Conflicts:
#	dolphinscheduler-bom/pom.xml
#	tools/dependencies/known-dependencies.txt
@zhaohehuhu
Copy link
Contributor Author

zhaohehuhu commented May 6, 2023 •
edited
Loading

@zhaohehuhu do you mind solving the conflict? and we will merge ASAP after that

done. Plz merge later

@zhongjiajie
Copy link
Member

approval CI

@sonarcloud
Copy link

sonarcloud bot commented May 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 30 Code Smells

80.9% 80.9% Coverage
0.0% 0.0% Duplication

@zhongjiajie
Copy link
Member

restart the failed CI

zhongjiajie
zhongjiajie approved these changes May 6, 2023
View reviewed changes
Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

@zhongjiajie zhongjiajie merged commit f1e7862 into apache:dev May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Radeity Radeity Radeity left review comments

@zhongjiajie zhongjiajie zhongjiajie approved these changes

@fuchanghai fuchanghai fuchanghai left review comments

@SbloodyS SbloodyS SbloodyS left review comments

@kezhenxu94 kezhenxu94 Awaiting requested review from kezhenxu94

@Tianqi-Dotes Tianqi-Dotes Awaiting requested review from Tianqi-Dotes

@EricGao888 EricGao888 Awaiting requested review from EricGao888 EricGao888 is a code owner

@songjianet songjianet Awaiting requested review from songjianet songjianet is a code owner

@Amy0104 Amy0104 Awaiting requested review from Amy0104

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@zhuangchong zhuangchong Awaiting requested review from zhuangchong

Assignees

@zhaohehuhu zhaohehuhu

Labels
3.2.0 for 3.2.0 version backend document feature new feature UI ui and front end related
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

[Feature][plugin] Support Snowflake datasource
7 participants
@zhaohehuhu @fuchanghai @codecov-commenter @Radeity @zhongjiajie @SbloodyS @tongwl