-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature-13429][Remote Logging] Add support for writing task logs to Google Cloud Storage #13777
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #13777 +/- ##
============================================
- Coverage 39.09% 39.03% -0.07%
- Complexity 4434 4438 +4
============================================
Files 1142 1143 +1
Lines 42007 42065 +58
Branches 4740 4739 -1
============================================
- Hits 16424 16421 -3
- Misses 23783 23847 +64
+ Partials 1800 1797 -3
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
...-common/src/main/java/org/apache/dolphinscheduler/common/log/remote/GcsRemoteLogHandler.java
Outdated
Show resolved
Hide resolved
...-common/src/main/java/org/apache/dolphinscheduler/common/log/remote/GcsRemoteLogHandler.java
Outdated
Show resolved
Hide resolved
edbcc17
to
33db3f8
Compare
|
...-common/src/main/java/org/apache/dolphinscheduler/common/log/remote/GcsRemoteLogHandler.java
Outdated
Show resolved
Hide resolved
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/LogUtils.java
Show resolved
Hide resolved
33db3f8
to
5c42f99
Compare
Hi, @caishunfeng , thanks a lot for your comment. I've update the pom |
5c42f99
to
3932e19
Compare
…Google Cloud Storage
3932e19
to
37fbae2
Compare
SonarCloud Quality Gate failed. |
Hi, @caishunfeng , could you please help review this again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose of the pull request
Brief change log
Verify this pull request
manually test and UT