Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature-13429][Remote Logging] Add support for writing task logs to Google Cloud Storage #13777

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

rickchengx
Copy link
Contributor

Purpose of the pull request

Brief change log

Verify this pull request

manually test and UT

  1. run a shell task

截屏2023-03-22 10 45 35

  1. check log file on GCS

截屏2023-03-22 10 45 02

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2023

Codecov Report

Merging #13777 (cd1d55f) into dev (9df89cf) will decrease coverage by 0.07%.
The diff coverage is 6.34%.

❗ Current head cd1d55f differs from pull request most recent head 37fbae2. Consider uploading reports for the commit 37fbae2 to get more accurate results

@@             Coverage Diff              @@
##                dev   #13777      +/-   ##
============================================
- Coverage     39.09%   39.03%   -0.07%     
- Complexity     4434     4438       +4     
============================================
  Files          1142     1143       +1     
  Lines         42007    42065      +58     
  Branches       4740     4739       -1     
============================================
- Hits          16424    16421       -3     
- Misses        23783    23847      +64     
+ Partials       1800     1797       -3     
Impacted Files Coverage Δ
...e/dolphinscheduler/common/constants/Constants.java 75.00% <ø> (ø)
...heduler/common/log/remote/GcsRemoteLogHandler.java 0.00% <0.00%> (ø)
...ler/common/log/remote/RemoteLogHandlerFactory.java 0.00% <0.00%> (ø)
...apache/dolphinscheduler/common/utils/LogUtils.java 1.40% <0.00%> (+1.40%) ⬆️
...hinscheduler/common/log/remote/RemoteLogUtils.java 25.00% <100.00%> (+4.31%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@caishunfeng
Copy link
Contributor

image
Hi @rickchengx please check the fail CI case.

@rickchengx
Copy link
Contributor Author

image Hi @rickchengx please check the fail CI case.

Hi, @caishunfeng , thanks a lot for your comment. I've update the pom

@rickchengx rickchengx marked this pull request as draft March 29, 2023 02:49
@rickchengx rickchengx marked this pull request as ready for review March 30, 2023 06:28
@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

3.9% 3.9% Coverage
0.0% 0.0% Duplication

@rickchengx rickchengx requested review from caishunfeng and removed request for EricGao888 and Tianqi-Dotes March 30, 2023 07:27
@rickchengx
Copy link
Contributor Author

Hi, @caishunfeng , could you please help review this again?

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version backend document feature new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Remote Logging] Add support for writing task logs to Google Cloud Storage
5 participants