-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix-13780][api] Fix the problem of process instance DAG can't show dependent task #13823
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change your target branch to dev
. @ralphgj
@SbloodyS Could you merge this pr or any other suggestions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI passed.
@ralphgj Please pull the latest dev code and push again. |
@SbloodyS done |
Codecov Report
@@ Coverage Diff @@
## dev #13823 +/- ##
============================================
- Coverage 38.90% 38.87% -0.04%
+ Complexity 4458 4453 -5
============================================
Files 1158 1158
Lines 42429 42430 +1
Branches 4776 4776
============================================
- Hits 16506 16493 -13
- Misses 24107 24120 +13
- Partials 1816 1817 +1
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Thanks for your contribution. This is a good beginning. Considering that it's your first contribution, I think we can get deep communication, you can contact me through mail or add WeChat(SbloodyS), when mail or added, please tell me who you are. I think I can help to familiar with the Dolphinscheduler if you meet with problems. @ralphgj |
…can't show dependent task #13823
Purpose of the pull request
close #13780
Brief change log
Fix the problem of process instance DAG can't show dependent task
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md