Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-13780][api] Fix the problem of process instance DAG can't show dependent task #13823

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

ralphgj
Copy link
Contributor

@ralphgj ralphgj commented Mar 29, 2023

Purpose of the pull request

close #13780

Brief change log

Fix the problem of process instance DAG can't show dependent task

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@SbloodyS SbloodyS added bug Something isn't working 3.1.x for 3.1.x version first time contributor First-time contributor labels Mar 30, 2023
@SbloodyS SbloodyS added this to the 3.1.5 milestone Mar 30, 2023
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change your target branch to dev. @ralphgj

@ralphgj
Copy link
Contributor Author

ralphgj commented Apr 12, 2023

@SbloodyS Could you merge this pr or any other suggestions?

SbloodyS
SbloodyS previously approved these changes Apr 12, 2023
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passed.

@SbloodyS
Copy link
Member

@ralphgj Please pull the latest dev code and push again.

@ralphgj
Copy link
Contributor Author

ralphgj commented Apr 12, 2023

@SbloodyS done

@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2023

Codecov Report

Merging #13823 (408882f) into dev (f9f88cb) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

❗ Current head 408882f differs from pull request most recent head eb26d05. Consider uploading reports for the commit eb26d05 to get more accurate results

@@             Coverage Diff              @@
##                dev   #13823      +/-   ##
============================================
- Coverage     38.90%   38.87%   -0.04%     
+ Complexity     4458     4453       -5     
============================================
  Files          1158     1158              
  Lines         42429    42430       +1     
  Branches       4776     4776              
============================================
- Hits          16506    16493      -13     
- Misses        24107    24120      +13     
- Partials       1816     1817       +1     
Impacted Files Coverage Δ
...ver/master/runner/task/DependentTaskProcessor.java 9.30% <0.00%> (ø)
...r/api/service/impl/ProcessInstanceServiceImpl.java 60.00% <75.00%> (+0.07%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

62.5% 62.5% Coverage
0.0% 0.0% Duplication

@fuchanghai
Copy link
Member

@SbloodyS

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SbloodyS SbloodyS merged commit 7835ddf into apache:dev Apr 19, 2023
@SbloodyS
Copy link
Member

Thanks for your contribution. This is a good beginning. Considering that it's your first contribution, I think we can get deep communication, you can contact me through mail or add WeChat(SbloodyS), when mail or added, please tell me who you are. I think I can help to familiar with the Dolphinscheduler if you meet with problems. @ralphgj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.1.x for 3.1.x version backend bug Something isn't working first time contributor First-time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [API] Process instance DAG can't show dependent task
5 participants