fix: when sudo enable is false, execute command will failed #13860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huangxinan1990
requested review from
caishunfeng,
SbloodyS and
zhuangchong
as code owners
SbloodyS
reviewed
Apr 3, 2023
There was a problem hiding this comment.
Would you please link your PR to your issue? @huangxinan1990
SbloodyS
added
bug
Codecov Report
@@ Coverage Diff @@
## dev #13860 +/- ##
=========================================
Coverage 39.10% 39.10%
+ Complexity 4466 4460 -6
=========================================
Files 1155 1155
Lines 42268 42268
Branches 4756 4760 +4
=========================================
Hits 16531 16531
Misses 23925 23925
Partials 1812 1812
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed! |
|
@SbloodyS has already add the issue |
rickchengx
approved these changes
Apr 7, 2023
|
@SbloodyS @caishunfeng @zhuangchong please help to review, thanks |
zhuangchong
approved these changes
Apr 7, 2023
zhuangchong
added
3.1.x
zhuangchong
pushed a commit
that referenced
this pull request
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #13876
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md