Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Bug】 OracleSouce edited again, ConnectionType is null #13881

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

AliceXiaoLu
Copy link
Contributor

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@AliceXiaoLu
Copy link
Contributor Author

@caishunfeng please review

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023

Codecov Report

Merging #13881 (49eda1a) into dev (7ee66f2) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 49eda1a differs from pull request most recent head 0404e0f. Consider uploading reports for the commit 0404e0f to get more accurate results

@@            Coverage Diff            @@
##                dev   #13881   +/-   ##
=========================================
  Coverage     38.86%   38.86%           
+ Complexity     4457     4454    -3     
=========================================
  Files          1158     1158           
  Lines         42424    42425    +1     
  Branches       4772     4776    +4     
=========================================
+ Hits          16487    16488    +1     
+ Misses        24123    24122    -1     
- Partials       1814     1815    +1     
Impacted Files Coverage Δ
...source/oracle/param/OracleDataSourceProcessor.java 48.14% <0.00%> (-0.91%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@rickchengx
Copy link
Contributor

Hi, @AliceXiaoLu , thanks for your work. Could you please update the related UT?

@AliceXiaoLu
Copy link
Contributor Author

Hi, @AliceXiaoLu , thanks for your work. Could you please update the related UT?

What exactly is UT? For example???

@rickchengx
Copy link
Contributor

Hi, @AliceXiaoLu , thanks for your work. Could you please update the related UT?

What exactly is UT? For example???

Maybe you could check and update the OracleDataSourceProcessorTest to test the case of this PR :)

@AliceXiaoLu
Copy link
Contributor Author

Hi, @AliceXiaoLu , thanks for your work. Could you please update the related UT?

What exactly is UT? For example???

Maybe you could check and update the OracleDataSourceProcessorTest to test the case of this PR :)

Yes, OracleDataSourceProcessorTest has this case. and is right。

@AliceXiaoLu
Copy link
Contributor Author

@caishunfeng Please help me to add Label,Thank you. Lable must include one of the following: feature, bug, improvement, document, chore AND Label must include one or more version numbers.

@AliceXiaoLu
Copy link
Contributor Author

@caishunfeng +1

@AliceXiaoLu
Copy link
Contributor Author

@rickchengx Please help to review

@rickchengx
Copy link
Contributor

rickchengx commented Apr 18, 2023

@rickchengx Please help to review

  • LGTM, please check the failed CI
  • And could you please add the related issue link in the PR, E.g., close: #issue

cc @caishunfeng

@SbloodyS SbloodyS added bug Something isn't working 3.1.x for 3.1.x version labels Apr 19, 2023
@SbloodyS SbloodyS added this to the 3.1.6 milestone Apr 19, 2023
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.1.x for 3.1.x version backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants