-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【Bug】 OracleSouce edited again, ConnectionType is null #13881
Conversation
@caishunfeng please review |
Codecov Report
@@ Coverage Diff @@
## dev #13881 +/- ##
=========================================
Coverage 38.86% 38.86%
+ Complexity 4457 4454 -3
=========================================
Files 1158 1158
Lines 42424 42425 +1
Branches 4772 4776 +4
=========================================
+ Hits 16487 16488 +1
+ Misses 24123 24122 -1
- Partials 1814 1815 +1
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Kudos, SonarCloud Quality Gate passed! |
Hi, @AliceXiaoLu , thanks for your work. Could you please update the related UT? |
What exactly is UT? For example??? |
Maybe you could check and update the |
Yes, OracleDataSourceProcessorTest has this case. and is right。 |
@caishunfeng Please help me to add Label,Thank you. Lable must include one of the following: feature, bug, improvement, document, chore AND Label must include one or more version numbers. |
@caishunfeng +1 |
@rickchengx Please help to review |
cc @caishunfeng |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md