[Bug] [Api] Resource files need to be checked before submitting #13887
Conversation
qingwli
commented
Apr 7, 2023
qingwli
commented
- close [Bug] [Api] Run process will throw exception when resource removed #13886
| Arrays.stream(this.resourceIds.split(",")).map(Integer::parseInt).toArray(Integer[]::new); | ||
|
|
||
| if (resourceIdArray.length > 0) { | ||
| List<Resource> list = processService.listResourceByIds(resourceIdArray); |
There was a problem hiding this comment.
Since we have refactored the resource center in #12076, ResourceMapper has been deprecated. I think we should not do this way.
There was a problem hiding this comment.
Since we have refactored the resource center in #12076, ResourceMapper has been deprecated. I think we should not do this way.
Add this pre-check and throw an explicit error msg during task execution, which one is better?
There was a problem hiding this comment.
Add this pre-check and throw an explicit error msg during task execution, which one is better?
If the user deletes files in third-party storage after passing the pre check, it also cannot avoid runtime errors...
There was a problem hiding this comment.
In our scenario, we are currently using the 3.1.1 version and I don't know we have refactored about resource center in dev.
And for the 3.1.1 version, we encountered this situation.
Here are the prerequisites:
- User can't access third-party storage directly.
- User only can operate third-party by ds platform.
- We can't delete the resource that binds online released jobs.
process -> task job -> resource table -> third-party storage
And if a process is maintained by a team. One member A operates offline this process. Another member B can delete resource binds in this process by ds. Member A re-online this process and got successful. Will throw an exception during runtime. And If we add a pre-check will find this exception when online.
There was a problem hiding this comment.
And I agree if the user deletes a third-party storage file directly and we can do nothing about this.
There was a problem hiding this comment.
This code only takes effect in version 3.1.X. And I'm +0 on this. cc @ruanwenjun @zhongjiajie @EricGao888 @caishunfeng
There was a problem hiding this comment.
Maybe we can post this change to 3.1.6, not dev. Because dev is totally different.
| @@ -293,6 +293,7 @@ public enum Status { | |||
| RESOURCE_HAS_FOLDER(20018, "There are files or folders in the current directory:{0}", "当前目录下有文件或文件夹[{0}]"), | |||
|
|
|||
| REMOVE_TASK_INSTANCE_CACHE_ERROR(20019, "remove task instance cache error", "删除任务实例缓存错误"), | |||
| TASK_RESOURCE_NOT_EXIST(20020, "Task {0} contains removed resource", "任务[{0}]含有被删除的资源文件"), | |||
There was a problem hiding this comment.
Maybe it's better to return the resource doesn't exist
|
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs. |
|
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request. |
