Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [worker] WorkerConfig output is wrong (#14000) #14001

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

klaokai
Copy link
Contributor

@klaokai klaokai commented Apr 24, 2023

Purpose of the pull request

fix output, close #14000

Brief change log

print is wrong

Verify this pull request

@SbloodyS SbloodyS added bug Something isn't working first time contributor First-time contributor 3.1.6 labels Apr 24, 2023
@SbloodyS SbloodyS added this to the 3.1.6 milestone Apr 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2023

Codecov Report

Merging #14001 (10f3670) into dev (51afbfe) will increase coverage by 0.00%.
The diff coverage is 42.52%.

❗ Current head 10f3670 differs from pull request most recent head 2559606. Consider uploading reports for the commit 2559606 to get more accurate results

@@            Coverage Diff            @@
##                dev   #14001   +/-   ##
=========================================
  Coverage     38.91%   38.91%           
- Complexity     4459     4472   +13     
=========================================
  Files          1158     1164    +6     
  Lines         42418    42445   +27     
  Branches       4777     4761   -16     
=========================================
+ Hits          16506    16517   +11     
- Misses        24095    24107   +12     
- Partials       1817     1821    +4     
Impacted Files Coverage Δ
...inscheduler/api/controller/ExecutorController.java 17.94% <0.00%> (ø)
...er/api/controller/ProcessDefinitionController.java 58.62% <ø> (ø)
...uler/api/controller/ProcessInstanceController.java 69.56% <ø> (ø)
...nscheduler/api/controller/ResourcesController.java 53.70% <0.00%> (-1.02%) ⬇️
...nscheduler/api/controller/SchedulerController.java 82.60% <ø> (ø)
...eduler/api/dto/workflow/WorkflowCreateRequest.java 100.00% <ø> (ø)
...eduler/api/dto/workflow/WorkflowUpdateRequest.java 36.36% <ø> (-5.31%) ⬇️
...che/dolphinscheduler/api/python/PythonGateway.java 16.94% <0.00%> (-0.30%) ⬇️
...org/apache/dolphinscheduler/api/vo/ScheduleVo.java 0.00% <0.00%> (ø)
...cheduler/common/constants/DataSourceConstants.java 0.00% <ø> (ø)
... and 56 more

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@zhongjiajie
Copy link
Member

good catch, and I had restart the failed CI

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working first time contributor First-time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [worker] WorkerConfig output is wrong
5 participants