-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][K8S Task] support node selector #14126
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #14126 +/- ##
============================================
+ Coverage 38.39% 38.40% +0.01%
- Complexity 4455 4456 +1
============================================
Files 1223 1223
Lines 42543 42563 +20
Branches 4715 4716 +1
============================================
+ Hits 16334 16347 +13
Misses 24413 24413
- Partials 1796 1803 +7
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-node-selectors.ts
Show resolved
Hide resolved
It's a good feature for k8s task. |
Agree with you, i can help with that. |
Hi, @caishunfeng, @SbloodyS, can you help re-run CI? |
3c73efe
to
44968c7
Compare
Done. |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Purpose of the pull request
Brief change log
Support same definition of
NodeSelectorRequirement
with https://kubernetes.io/docs/reference/kubernetes-api/common-definitions/node-selector-requirement/Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md