Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][K8S Task] support node selector #14126

Merged
merged 2 commits into from
May 26, 2023

Conversation

Radeity
Copy link
Member

@Radeity Radeity commented May 17, 2023

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@Radeity Radeity changed the title feat: support node selector [Feature][K8S Task] support node selector May 17, 2023
@github-actions github-actions bot added backend document UI ui and front end related labels May 17, 2023
@SbloodyS SbloodyS added feature new feature 3.2.0 for 3.2.0 version labels May 17, 2023
@SbloodyS SbloodyS added this to the 3.2.0 milestone May 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2023

Codecov Report

Merging #14126 (cabb569) into dev (74ed785) will increase coverage by 0.01%.
The diff coverage is 81.81%.

❗ Current head cabb569 differs from pull request most recent head 3c73efe. Consider uploading reports for the commit 3c73efe to get more accurate results

@@             Coverage Diff              @@
##                dev   #14126      +/-   ##
============================================
+ Coverage     38.39%   38.40%   +0.01%     
- Complexity     4455     4456       +1     
============================================
  Files          1223     1223              
  Lines         42543    42563      +20     
  Branches       4715     4716       +1     
============================================
+ Hits          16334    16347      +13     
  Misses        24413    24413              
- Partials       1796     1803       +7     
Impacted Files Coverage Δ
.../plugin/task/api/parameters/K8sTaskParameters.java 0.00% <ø> (ø)
...ache/dolphinscheduler/plugin/task/k8s/K8sTask.java 80.48% <66.66%> (-3.39%) ⬇️
...uler/plugin/task/api/k8s/impl/K8sTaskExecutor.java 38.50% <100.00%> (+3.47%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

caishunfeng
caishunfeng previously approved these changes May 18, 2023
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

@caishunfeng
Copy link
Contributor

It's a good feature for k8s task.
BTW, if ds deploy in k8s, node selector is the same with worker group. Maybe we can replace worker group with node selector in k8s.

@Radeity
Copy link
Member Author

Radeity commented May 18, 2023

It's a good feature for k8s task. BTW, if ds deploy in k8s, node selector is the same with worker group. Maybe we can replace worker group with node selector in k8s.

Agree with you, i can help with that.

@Radeity
Copy link
Member Author

Radeity commented May 19, 2023

Hi, @caishunfeng, @SbloodyS, can you help re-run CI?

@SbloodyS
Copy link
Member

Hi, @caishunfeng, @SbloodyS, can you help re-run CI?

Done.

@sonarcloud
Copy link

sonarcloud bot commented May 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

85.7% 85.7% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@caishunfeng caishunfeng merged commit 4e78248 into apache:dev May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version backend document feature new feature UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants