Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default datax plugin #14204

Merged
merged 1 commit into from
Jun 25, 2023
Merged

Conversation

hantmac
Copy link
Contributor

@hantmac hantmac commented May 25, 2023

Purpose of the pull request

This pr fix default datax plugin, using RDBMS as default.
Fix #14180

@SbloodyS
Copy link
Member

Please associate PR to your issue.

@zhongjiajie
Copy link
Member

does datax use rdbms as its default plugin?

@hantmac
Copy link
Contributor Author

hantmac commented Jun 3, 2023

does datax use rdbms as its default plugin?

IMHO, datax use rdbms as default🤔.
image

@zhongjiajie zhongjiajie modified the milestones: 3.2.0, 3.1.8 Jun 3, 2023
@zhongjiajie zhongjiajie added the bug Something isn't working label Jun 3, 2023
@zhongjiajie zhongjiajie added the 3.1.x for 3.1.x version label Jun 3, 2023
Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2023

Codecov Report

Merging #14204 (22ee1c8) into dev (c6ac356) will decrease coverage by 0.02%.
The diff coverage is 4.61%.

❗ Current head 22ee1c8 differs from pull request most recent head 4862a84. Consider uploading reports for the commit 4862a84 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14204      +/-   ##
============================================
- Coverage     38.36%   38.34%   -0.02%     
- Complexity     4469     4473       +4     
============================================
  Files          1229     1229              
  Lines         42887    42911      +24     
  Branches       4764     4764              
============================================
+ Hits          16454    16456       +2     
- Misses        24608    24632      +24     
+ Partials       1825     1823       -2     
Impacted Files Coverage Δ
.../server/master/runner/WorkflowExecuteRunnable.java 10.31% <0.00%> (-0.07%) ⬇️
...er/master/runner/operator/TaskTimeoutOperator.java 0.00% <0.00%> (ø)
...dolphinscheduler/plugin/task/datax/DataxUtils.java 0.00% <0.00%> (ø)
...nscheduler/service/process/ProcessServiceImpl.java 30.94% <11.53%> (-0.05%) ⬇️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

19.8% 19.8% Coverage
0.6% 0.6% Duplication

Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, rerun failed CI

@zhongjiajie
Copy link
Member

restart the failed E2E

@rickchengx rickchengx merged commit 9c92b4b into apache:dev Jun 25, 2023
zhuangchong pushed a commit that referenced this pull request Jun 26, 2023
IT-Kwj pushed a commit to IT-Kwj/dolphinscheduler that referenced this pull request Jul 14, 2023
zhongjiajie pushed a commit that referenced this pull request Jul 20, 2023
(cherry picked from commit 9c92b4b)
biaoma-ty pushed a commit to Kasma-Inc/dolphinscheduler that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.1.x for 3.1.x version backend bug Something isn't working ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Datax] getReaderPluginName may return null
6 participants