Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][API] Fix TreeView "Task Status" not show bug and compatibility with older versions use WorkflowExecutionStatus.name() #14207

Merged
merged 1 commit into from
May 29, 2023

Conversation

scorpig
Copy link
Contributor

@scorpig scorpig commented May 25, 2023

…versions

use WorkflowExecutionStatus.name()

Appeared after 3.1.0

Purpose of the pull request

fix #14219

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@caishunfeng caishunfeng changed the title Fix TreeView "Task Status" not show bug and compatibility with older … Fix TreeView "Task Status" not show bug and compatibility with older versions use WorkflowExecutionStatus.name() May 26, 2023
@caishunfeng caishunfeng changed the title Fix TreeView "Task Status" not show bug and compatibility with older versions use WorkflowExecutionStatus.name() [Bug][API] Fix TreeView "Task Status" not show bug and compatibility with older versions use WorkflowExecutionStatus.name() May 26, 2023
@caishunfeng
Copy link
Contributor

Hi @scorpig please link a issue for this pr description, and let we know which version you want to fix?

@caishunfeng caishunfeng added the bug Something isn't working label May 26, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #14207 (74d8b93) into dev (d810c48) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 74d8b93 differs from pull request most recent head d21efd8. Consider uploading reports for the commit d21efd8 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14207      +/-   ##
============================================
- Coverage     38.32%   38.31%   -0.02%     
+ Complexity     4470     4467       -3     
============================================
  Files          1229     1229              
  Lines         42915    42915              
  Branches       4762     4764       +2     
============================================
- Hits          16448    16442       -6     
- Misses        24644    24649       +5     
- Partials       1823     1824       +1     
Impacted Files Coverage Δ
...api/service/impl/ProcessDefinitionServiceImpl.java 35.35% <0.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented May 26, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@scorpig
Copy link
Contributor Author

scorpig commented May 26, 2023

#14219

@scorpig
Copy link
Contributor Author

scorpig commented May 29, 2023

Hi @scorpig please link a issue for this pr description, and let we know which version you want to fix?

#14219

@SbloodyS SbloodyS added this to the 3.1.8 milestone May 29, 2023
@SbloodyS SbloodyS added 3.1.x for 3.1.x version first time contributor First-time contributor labels May 29, 2023
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SbloodyS SbloodyS merged commit b8748e2 into apache:dev May 29, 2023
zhuangchong pushed a commit that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.1.x for 3.1.x version backend bug Something isn't working first time contributor First-time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [API] TreeView "Task Status" not show bug
5 participants