[Bug] [Seatunnel-Task] Run Mode defaults to run, and you cannot select a null value #14267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyfjrx
requested review from
songjianet,
caishunfeng,
SbloodyS and
zhuangchong
as code owners
Codecov Report
@@ Coverage Diff @@
## dev #14267 +/- ##
============================================
- Coverage 38.45% 38.42% -0.04%
+ Complexity 4499 4497 -2
============================================
Files 1235 1235
Lines 42992 42992
Branches 4765 4765
============================================
- Hits 16534 16521 -13
- Misses 24631 24644 +13
Partials 1827 1827 see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed! |
3 tasks
songjianet
approved these changes
Jul 12, 2023
IT-Kwj
pushed a commit
to IT-Kwj/dolphinscheduler
that referenced
this pull request
Jul 14, 2023
…t a null value (apache#14267) Co-authored-by: zhang <zhangyfcoder@163.com>
zhuangchong
pushed a commit
that referenced
this pull request
Jul 20, 2023
…cannot select a null value #14267
3 tasks
biaoma-ty
pushed a commit
to Kasma-Inc/dolphinscheduler
that referenced
this pull request
Aug 17, 2023
…t a null value (apache#14267) Co-authored-by: zhang <zhangyfcoder@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #14250
Purpose of the pull request
When Dolphinscheduler creates a seattunnel task, if the Flink startup script is used, the Run Mode defaults to run, and a null value cannot be selected. As a result of this operation, when seatunnel invokes the Flink service to perform tasks, --run-mode run will be spliced by default in the execution command, but the run-mode parameter is not supported in multiple flink versions (tested 1.13 1.14 1.15 1.16 1.17), and finally Task execution failed.
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md