-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature-14505][UI] Support to set project-level preferences #14573
[Feature-14505][UI] Support to set project-level preferences #14573
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preferences parameter currently being replaced at the frontend level. We have many users who directly call APIs to use them. So I think it's better to set these preferences parameter in the backend level.
BTW, you should update the docs too.
|
...src/main/java/org/apache/dolphinscheduler/api/service/impl/ProjectPreferenceServiceImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/dolphinscheduler/api/service/impl/ProjectPreferenceServiceImpl.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## dev #14573 +/- ##
=========================================
Coverage 38.46% 38.47%
- Complexity 4538 4545 +7
=========================================
Files 1252 1254 +2
Lines 43611 43709 +98
Branches 4790 4824 +34
=========================================
+ Hits 16775 16815 +40
- Misses 24968 25018 +50
- Partials 1868 1876 +8
... and 33 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature is very good. It can reduce the steps of user operations, improve user interaction experience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Kudos, SonarCloud Quality Gate passed! |
* add a few codes about the project preferences (cherry picked from commit 20cf4ad)
…14573) * add a few codes about the project preferences
Purpose of the pull request
This PR will close #14505 .
Brief change log
Verify this pull request
This change added tests and can be verified as follows:
The test results are as follows: