Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature-14505][UI] Support to set project-level preferences #14573

Merged
merged 17 commits into from
Jul 19, 2023

Conversation

calvinjiang
Copy link
Contributor

Purpose of the pull request

This PR will close #14505 .

Brief change log

Verify this pull request

This change added tests and can be verified as follows:

  • Manually verified the change by testing locally.

The test results are as follows:
image

image

@github-actions github-actions bot added UI ui and front end related backend labels Jul 18, 2023
@mergeable mergeable bot removed UI ui and front end related backend labels Jul 18, 2023
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preferences parameter currently being replaced at the frontend level. We have many users who directly call APIs to use them. So I think it's better to set these preferences parameter in the backend level.

BTW, you should update the docs too.

@SbloodyS SbloodyS added miss:docs missing documents in PR UI ui and front end related backend labels Jul 18, 2023
@calvinjiang
Copy link
Contributor Author

The preferences parameter currently being replaced at the frontend level. We have many users who directly call APIs to use them. So I think it's better to set these preferences parameter in the backend level.

BTW, you should update the docs too.
This new functionality provides an easy way to help users create tasks and workflows. Just when creating the task and workflow it'll be able to affect the default value of components on their forms. These project-level preferences are not required and users can decide what kind of preferences to use.

@calvinjiang calvinjiang added the 3.2.0 for 3.2.0 version label Jul 18, 2023
@calvinjiang calvinjiang added this to the 3.2.0 milestone Jul 18, 2023
@calvinjiang calvinjiang added the feature new feature label Jul 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

Merging #14573 (88a4090) into dev (c30cca9) will increase coverage by 0.00%.
The diff coverage is 67.92%.

❗ Current head 88a4090 differs from pull request most recent head 61b4dcf. Consider uploading reports for the commit 61b4dcf to get more accurate results

@@            Coverage Diff            @@
##                dev   #14573   +/-   ##
=========================================
  Coverage     38.46%   38.47%           
- Complexity     4538     4545    +7     
=========================================
  Files          1252     1254    +2     
  Lines         43611    43709   +98     
  Branches       4790     4824   +34     
=========================================
+ Hits          16775    16815   +40     
- Misses        24968    25018   +50     
- Partials       1868     1876    +8     
Impacted Files Coverage Δ
...api/service/impl/ProjectPreferenceServiceImpl.java 63.04% <63.04%> (ø)
...er/api/controller/ProjectPreferenceController.java 100.00% <100.00%> (ø)
.../org/apache/dolphinscheduler/api/enums/Status.java 100.00% <100.00%> (ø)

... and 33 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature is very good. It can reduce the steps of user operations, improve user interaction experience.

Copy link
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 19 Code Smells

69.8% 69.8% Coverage
0.0% 0.0% Duplication

@calvinjiang calvinjiang merged commit 20cf4ad into apache:dev Jul 19, 2023
zhongjiajie pushed a commit that referenced this pull request Jul 20, 2023
* add a few codes about the project preferences

(cherry picked from commit 20cf4ad)
biaoma-ty pushed a commit to Kasma-Inc/dolphinscheduler that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version backend feature new feature miss:docs missing documents in PR UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][UI] Support to set project-level preferences.
5 participants