Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support execute shell in different interceptor #14582

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Jul 19, 2023

Purpose of the pull request

  • Support running in sh.

Brief change log

  • Add IShellInterceptor.
  • Add IShellInterceptorBuilder to create IShellInterceptor.
  • Execute Shell script by IShellInterceptor.
  • Add implementation of bash, sh, cmd.

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun added the 3.2.0 for 3.2.0 version label Jul 19, 2023
@ruanwenjun ruanwenjun added this to the 3.2.0 milestone Jul 19, 2023
@ruanwenjun ruanwenjun added the feature new feature label Jul 19, 2023
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addShellInterceptor branch 2 times, most recently from 9febcbe to 8c66732 Compare July 19, 2023 05:53
zhongjiajie
zhongjiajie previously approved these changes Jul 19, 2023
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addShellInterceptor branch from 1ec9ba3 to 6801031 Compare July 19, 2023 06:16
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

Merging #14582 (ec283e2) into dev (804b715) will decrease coverage by 0.13%.
The diff coverage is 3.40%.

❗ Current head ec283e2 differs from pull request most recent head 6801031. Consider uploading reports for the commit 6801031 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14582      +/-   ##
============================================
- Coverage     38.58%   38.46%   -0.13%     
- Complexity     4541     4542       +1     
============================================
  Files          1241     1252      +11     
  Lines         43554    43656     +102     
  Branches       4832     4817      -15     
============================================
- Hits          16807    16791      -16     
- Misses        24875    24994     +119     
+ Partials       1872     1871       -1     
Impacted Files Coverage Δ
...duler/plugin/task/api/AbstractCommandExecutor.java 0.00% <0.00%> (ø)
...hinscheduler/plugin/task/api/AbstractYarnTask.java 0.00% <0.00%> (ø)
...cheduler/plugin/task/api/ShellCommandExecutor.java 0.00% <ø> (ø)
...sk/api/shell/BaseLinuxShellInterceptorBuilder.java 0.00% <0.00%> (ø)
...er/plugin/task/api/shell/BaseShellInterceptor.java 0.00% <0.00%> (ø)
...in/task/api/shell/BaseShellInterceptorBuilder.java 0.00% <0.00%> (ø)
.../api/shell/BaseWindowsShellInterceptorBuilder.java 0.00% <0.00%> (ø)
...task/api/shell/ShellInterceptorBuilderFactory.java 0.00% <0.00%> (ø)
...ugin/task/api/shell/bash/BashShellInterceptor.java 0.00% <0.00%> (ø)
...sk/api/shell/bash/BashShellInterceptorBuilder.java 0.00% <0.00%> (ø)
... and 19 more

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 18 Code Smells

2.8% 2.8% Coverage
7.5% 7.5% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit c30cca9 into apache:dev Jul 19, 2023
@ruanwenjun ruanwenjun deleted the dev_wenjun_addShellInterceptor branch July 19, 2023 06:50
zhongjiajie pushed a commit that referenced this pull request Jul 20, 2023
biaoma-ty pushed a commit to Kasma-Inc/dolphinscheduler that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version backend feature new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants